Re: [PATCH] firedtv: refine AVC debugging

2009-07-17 Thread Stefan Richter
Henrik Kurelid wrote: +#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 22) This expression is always true. :-) -- Stefan Richter -=-==--= -=== =---= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH] firedtv: refine AVC debugging

2009-07-17 Thread Stefan Richter
Henrik Kurelid wrote: +static int debug_fcp_opcode_flag_set(unsigned int opcode, +const u8 *data, int length) +{ + switch (opcode) { + case AVC_OPCODE_VENDOR: break; + case AVC_OPCODE_READ_DESCRIPTOR:return avc_debug

Re: [PATCH] firedtv: refine AVC debugging

2009-07-17 Thread Henrik Kurelid
Hi, I gave this some thought when I implemented it. These are should not happend-situations where the drivers or hardware sends unknown/unimplemented commands. Rather than making sure that they are never seen in the logs I wanted them to always be logged (as long as some debug logging is turned

Re: [PATCH] firedtv: refine AVC debugging

2009-07-17 Thread Stefan Richter
On 17 Jul, Henrik Kurelid wrote: [I wrote] Shouldn't the three return statements in debug_fcp_opcode_flag_set be 'return 0' rather than one? I gave this some thought when I implemented it. These are should not happend-situations where the drivers or hardware sends unknown/ unimplemented

Re: [PATCH] firedtv: refine AVC debugging

2009-07-17 Thread Stefan Richter
On 17 Jul, Henrik Kurelid wrote: [I wrote] Shouldn't the three return statements in debug_fcp_opcode_flag_set be 'return 0' rather than one? I gave this some thought when I implemented it. These are should not happend-situations where the drivers or hardware sends unknown/ unimplemented

[PATCH] firedtv: refine AVC debugging

2009-07-16 Thread Henrik Kurelid
Hi, Here is another patch for the firedtv driver. This one changes the debug logging somewhat to make it easier to find issues with the driver since it is still fairly untested for variants of delivery systems, CAMs and CA systems. --- firedtv: refine AVC debugging The current AVC debugging