[PATCH] gspca: implement vidioc_enum_frameintervals

2009-12-01 Thread Antonio Ospite
Some drivers support multiple frameintervals (framerates), make gspca able to enumerate them. Signed-off-by: Antonio Ospite --- Changes since the initial RFC version: - 'i' is now a __u32 and the variable 'index' has been dropped. - some more comments in gspca.h Thanks to Hans de Goede for the

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Jean-Francois Moine
On Thu, 19 Nov 2009 12:11:21 +0100 Hans de Goede wrote: > Hmm, I see now upon expecting the code that the driver does actually > support setting the framerate, but what I see does not seem > to match your patch, the driver seems to support 50, 40, 30 and 15 > fps, where as your patch has: > > st

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Hans de Goede
Hi, On 11/19/2009 11:37 AM, Antonio Ospite wrote: On Thu, 19 Nov 2009 09:08:22 +0100 Hans de Goede wrote: Hi, Hi, thanks for commenting on this. On 11/17/2009 11:41 AM, Antonio Ospite wrote: Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support mu

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Antonio Ospite
On Thu, 19 Nov 2009 09:08:22 +0100 Hans de Goede wrote: > Hi, > Hi, thanks for commenting on this. > On 11/17/2009 11:41 AM, Antonio Ospite wrote: > > Hi, > > > > gspca does not implement vidioc_enum_frameintervals yet, so even if a > > camera can support multiple frame rates (or frame interval

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Hans de Goede
Hi, On 11/19/2009 10:00 AM, Michael Trimarchi wrote: Hans de Goede wrote: Hi, On 11/17/2009 11:41 AM, Antonio Ospite wrote: Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support multiple frame rates (or frame intervals) there is still no way to enumerat

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Michael Trimarchi
Hans de Goede wrote: Hi, On 11/17/2009 11:41 AM, Antonio Ospite wrote: Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support multiple frame rates (or frame intervals) there is still no way to enumerate them from userspace. The following is just a quick a

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-19 Thread Hans de Goede
Hi, On 11/17/2009 11:41 AM, Antonio Ospite wrote: Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support multiple frame rates (or frame intervals) there is still no way to enumerate them from userspace. The following is just a quick and dirty implementatio

Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-17 Thread Michael Trimarchi
Hi, Antonio Ospite wrote: Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support multiple frame rates (or frame intervals) there is still no way to enumerate them from userspace. The following is just a quick and dirty implementation to show the problem an

[RFC, PATCH] gspca: implement vidioc_enum_frameintervals

2009-11-17 Thread Antonio Ospite
Hi, gspca does not implement vidioc_enum_frameintervals yet, so even if a camera can support multiple frame rates (or frame intervals) there is still no way to enumerate them from userspace. The following is just a quick and dirty implementation to show the problem and to have something to base t