Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-30 Thread Jarod Wilson
On Dec 29, 2009, at 5:30 PM, Dmitry Torokhov wrote: On Tue, Dec 29, 2009 at 12:04:00AM -0500, Jarod Wilson wrote: On Dec 28, 2009, at 4:31 AM, Dmitry Torokhov wrote: Hm, will this work on big-endian? Good question. Not sure offhand. Probably not. Unfortunately, the only devices I have

Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-30 Thread Jarod Wilson
On Dec 30, 2009, at 3:02 AM, Jarod Wilson wrote: On Dec 29, 2009, at 5:30 PM, Dmitry Torokhov wrote: On Tue, Dec 29, 2009 at 12:04:00AM -0500, Jarod Wilson wrote: On Dec 28, 2009, at 4:31 AM, Dmitry Torokhov wrote: Hm, will this work on big-endian? Good question. Not sure offhand.

Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-29 Thread Dan Carpenter
I ran smatch (http://repo.or.cz/w/smatch.git) on it and there are some bugs worth fixing. drivers/input/misc/imon.c +331 free_imon_context(7) error: dereferencing freed memory 'context' Move the debug line earlier. drivers/input/misc/imon.c +1812 imon_probe(216) error: dereferencing undefined:

Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-29 Thread Jarod Wilson
On 12/29/2009 12:01 PM, Dan Carpenter wrote: I ran smatch (http://repo.or.cz/w/smatch.git) on it and there are some bugs worth fixing. drivers/input/misc/imon.c +331 free_imon_context(7) error: dereferencing freed memory 'context' Move the debug line earlier. drivers/input/misc/imon.c +1812

Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-29 Thread Dmitry Torokhov
On Tue, Dec 29, 2009 at 12:04:00AM -0500, Jarod Wilson wrote: On Dec 28, 2009, at 4:31 AM, Dmitry Torokhov wrote: Hm, will this work on big-endian? Good question. Not sure offhand. Probably not. Unfortunately, the only devices I have to test with at the moment are integrated into cases

Re: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices

2009-12-28 Thread Jarod Wilson
Hey Dmitry, Thanks much for the review, comments inline below... On Dec 28, 2009, at 4:31 AM, Dmitry Torokhov wrote: Hi Jarod, On Mon, Dec 28, 2009 at 12:11:55AM -0500, Jarod Wilson wrote: This is an input layer driver for the SoundGraph iMON and Antec Veris IR and/or Display (LCD/VFD/VGA