Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

Hi Ales and HoP, Em Wed, 4 Nov 2009 09:35:51 +0100 Ales Jurik escreveu: > On Wednesday 04 of November 2009, HoP wrote: > > Hi Hermann, > > > > >> >> Attached patch adds two optional (so, disabled by default > > >> >> and therefore could not break any compatibility) features: > > >> >> > > >> >>

Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

On Wednesday 04 of November 2009, HoP wrote: > Hi Hermann, > > >> >> Attached patch adds two optional (so, disabled by default > >> >> and therefore could not break any compatibility) features: > >> >> > >> >> 1, tone_control=1 > >> >> When enabled, ISL6421 overrides frontend's tone control > >> >

Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

Hi Hermann, >> >> >> >> Attached patch adds two optional (so, disabled by default >> >> and therefore could not break any compatibility) features: >> >> >> >> 1, tone_control=1 >> >> When enabled, ISL6421 overrides frontend's tone control >> >> function (fe->ops.set_tone) by its own one. >> >> >>

Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

Hi Mauro, thank you for your valued hints. I'm commenting inside message: > First of all, please check all your patches with checkpatch, to be sure > that they don't have any CodingStyle troubles. There are some on your > patch (the better is to read README.patches for more info useful > for deve

Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

Hi Honza, Am Mittwoch, den 04.11.2009, 00:10 +0100 schrieb HoP: > Hi Mauro, > > thank you for your valued hints. I'm commenting inside > message: > > > First of all, please check all your patches with checkpatch, to be sure > > that they don't have any CodingStyle troubles. There are some on you

Re: [PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

HoP escreveu: Hi, this is my first kernel patch, so all comments are welcome. First of all, please check all your patches with checkpatch, to be sure that they don't have any CodingStyle troubles. There are some on your patch (the better is to read README.patches for more info useful for dev

[PATCH] isl6421.c - added optional features: tone control and temporary diseqc overcurrent

Hi, this is my first kernel patch, so all comments are welcome. Attached patch adds two optional (so, disabled by default and therefore could not break any compatibility) features: 1, tone_control=1 When enabled, ISL6421 overrides frontend's tone control function (fe->ops.set_tone) by its own on