Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

Em Thu, 29 Mar 2018 22:37:57 +0430 Nasser escreveu: > On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 29 Mar 2018 19:04:35 +0430 > > Nasser escreveu: > > > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430,

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch. > > > > May

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

Em Thu, 29 Mar 2018 19:04:35 +0430 Nasser escreveu: > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > Hi Mauro, > > Thank you for taking time to review my patch. > > May be I should rephrase the commit message to something like: > Use the default

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: Hi Mauro, Thank you for taking time to review my patch. May be I should rephrase the commit message to something like: Use the default register values as suggested in TVP5150AM1 datasheet As this is not a hardware-dependent issue.

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

On Mon, Mar 26, 2018 at 06:43:53AM -0300, Mauro Carvalho Chehab wrote: > Hi Nasser, > > Em Mon, 26 Mar 2018 03:26:33 +0430 > Nasser Afshin escreveu: > > > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > > resistor if it's been disabled. On

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

Hi Nasser, Em Mon, 26 Mar 2018 03:26:33 +0430 Nasser Afshin escreveu: > According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down > resistor if it's been disabled. On hardware that does not have such > resistor, we should use the default output enable

[PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down resistor if it's been disabled. On hardware that does not have such resistor, we should use the default output enable value. This prevents the color burst lock instability problem. Signed-off-by: Nasser Afshin