Re: [PATCH] media: imx214: don't de-reference a NULL pointer

2018-12-12 Thread Ricardo Ribalda Delgado
Hi Mauro, Hi Hans Thanks for taking a look at this. On Wed, Dec 12, 2018 at 6:55 PM Hans Verkuil wrote: > > On 12/7/18 12:43 PM, Mauro Carvalho Chehab wrote: > > As warned by smatch: > > drivers/media/i2c/imx214.c:591 imx214_set_format() warn: variable > > dereferenced before check 'format

Re: [PATCH] media: imx214: don't de-reference a NULL pointer

2018-12-12 Thread Hans Verkuil
On 12/7/18 12:43 PM, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/i2c/imx214.c:591 imx214_set_format() warn: variable > dereferenced before check 'format' (see line 589) > > It turns that the code at imx214_set_format() has support for being > called with the format b

[PATCH] media: imx214: don't de-reference a NULL pointer

2018-12-07 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/i2c/imx214.c:591 imx214_set_format() warn: variable dereferenced before check 'format' (see line 589) It turns that the code at imx214_set_format() has support for being called with the format being NULL. I've no idea why, as it is only called internally