Re: [PATCH] media: ov9650: remove unnecessary terminated entry in menu items array

2017-10-25 Thread Sakari Ailus
On Thu, Oct 26, 2017 at 12:22:14AM +0900, Akinobu Mita wrote: > Hi Sakari, > > 2017-10-25 19:23 GMT+09:00 Sakari Ailus : > > On Tue, Oct 24, 2017 at 02:30:26AM +0900, Akinobu Mita wrote: > >> The test_pattern_menu[] array has two valid items and a null terminated > >> item.

Re: [PATCH] media: ov9650: remove unnecessary terminated entry in menu items array

2017-10-25 Thread Akinobu Mita
Hi Sakari, 2017-10-25 19:23 GMT+09:00 Sakari Ailus : > On Tue, Oct 24, 2017 at 02:30:26AM +0900, Akinobu Mita wrote: >> The test_pattern_menu[] array has two valid items and a null terminated >> item. So the control's maximum value which is passed to >>

Re: [PATCH] media: ov9650: remove unnecessary terminated entry in menu items array

2017-10-25 Thread Sakari Ailus
On Tue, Oct 24, 2017 at 02:30:26AM +0900, Akinobu Mita wrote: > The test_pattern_menu[] array has two valid items and a null terminated > item. So the control's maximum value which is passed to > v4l2_ctrl_new_std_menu_items() should be one. However, > 'ARRAY_SIZE(test_pattern_menu) - 1' is

[PATCH] media: ov9650: remove unnecessary terminated entry in menu items array

2017-10-23 Thread Akinobu Mita
The test_pattern_menu[] array has two valid items and a null terminated item. So the control's maximum value which is passed to v4l2_ctrl_new_std_menu_items() should be one. However, 'ARRAY_SIZE(test_pattern_menu) - 1' is actually passed and it's not correct. Fix it by removing unnecessary