Re: [PATCH] media: uvcvideo: Prevent setting unavailable flags

2018-04-11 Thread Guennadi Liakhovetski
Hi Kieran, Thanks for the patch, it fixed a problem I was having with media master, working with a Logitech UVC 1.5 camera. On Wed, 21 Mar 2018, Kieran Bingham wrote: > The addition of an extra operation to use the GET_INFO command > overwrites all existing flags from the uvc_ctrls table. This

Re: [PATCH] media: uvcvideo: Prevent setting unavailable flags

2018-03-21 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Wednesday, 21 March 2018 17:43:08 EET Kieran Bingham wrote: > The addition of an extra operation to use the GET_INFO command > overwrites all existing flags from the uvc_ctrls table. This includes > setting all controls as supporting GET_MIN, GET_MAX,

[PATCH] media: uvcvideo: Prevent setting unavailable flags

2018-03-21 Thread Kieran Bingham
The addition of an extra operation to use the GET_INFO command overwrites all existing flags from the uvc_ctrls table. This includes setting all controls as supporting GET_MIN, GET_MAX, GET_RES, and GET_DEF regardless of whether they do or not. Move the initialisation of these control