Re: [PATCH] media: video-i2c: don't use msleep for 1ms - 20ms
On 11/20/2018 04:27 PM, Akinobu Mita wrote: > Documentation/timers/timers-howto.txt says: > > "msleep(1~20) may not do what the caller intends, and will often sleep > longer (~20 ms actual sleep for any value given in the 1~20ms range)." > > So replace msleep(2) by usleep_range(2000, 3000). Please just repost patch 6/6 with this change merged in. Thanks! Hans > > Reported-by: Hans Verkuil > Cc: Matt Ranostay > Cc: Sakari Ailus > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > This fixes "[PATCH v4 6/6] media: video-i2c: support runtime PM" in the > patchset "[PATCH v4 0/6] media: video-i2c: support changing frame interval > and runtime PM". > > drivers/media/i2c/video-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c > index 0c82131..77080d7 100644 > --- a/drivers/media/i2c/video-i2c.c > +++ b/drivers/media/i2c/video-i2c.c > @@ -155,7 +155,7 @@ static int amg88xx_set_power_on(struct video_i2c_data > *data) > if (ret) > return ret; > > - msleep(2); > + usleep_range(2000, 3000); > > ret = regmap_write(data->regmap, AMG88XX_REG_RST, AMG88XX_RST_FLAG); > if (ret) >
Re: [PATCH] media: video-i2c: don't use msleep for 1ms - 20ms
On Wed, Nov 21, 2018 at 12:27:40AM +0900, Akinobu Mita wrote: > Documentation/timers/timers-howto.txt says: > > "msleep(1~20) may not do what the caller intends, and will often sleep > longer (~20 ms actual sleep for any value given in the 1~20ms range)." > > So replace msleep(2) by usleep_range(2000, 3000). > > Reported-by: Hans Verkuil > Cc: Matt Ranostay > Cc: Sakari Ailus > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita Acked-by: Sakari Ailus -- Sakari Ailus sakari.ai...@linux.intel.com
[PATCH] media: video-i2c: don't use msleep for 1ms - 20ms
Documentation/timers/timers-howto.txt says: "msleep(1~20) may not do what the caller intends, and will often sleep longer (~20 ms actual sleep for any value given in the 1~20ms range)." So replace msleep(2) by usleep_range(2000, 3000). Reported-by: Hans Verkuil Cc: Matt Ranostay Cc: Sakari Ailus Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- This fixes "[PATCH v4 6/6] media: video-i2c: support runtime PM" in the patchset "[PATCH v4 0/6] media: video-i2c: support changing frame interval and runtime PM". drivers/media/i2c/video-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 0c82131..77080d7 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -155,7 +155,7 @@ static int amg88xx_set_power_on(struct video_i2c_data *data) if (ret) return ret; - msleep(2); + usleep_range(2000, 3000); ret = regmap_write(data->regmap, AMG88XX_REG_RST, AMG88XX_RST_FLAG); if (ret) -- 2.7.4