RE: [PATCH] media: videobuf2-dma-contig: include header for exported symbols

[Marek Szyprowski]

Hi,

On Wednesday, April 25, 2012 1:08 AM H Hartley Sweeten wrote:

 Include the header to pickup the definitions of the exported symbols.
 
 Quiets the following sparse warnings:
 
 warning: symbol 'vb2_dma_contig_memops' was not declared. Should it be static?
 warning: symbol 'vb2_dma_contig_init_ctx' was not declared. Should it be 
 static?
 warning: symbol 'vb2_dma_contig_cleanup_ctx' was not declared. Should it be 
 static?
 
 Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
 Cc: Pawel Osciak pa...@osciak.com
 Cc: Marek Szyprowski m.szyprow...@samsung.com
 Cc: Kyungmin Park kyungmin.p...@samsung.com
 Cc: Mauro Carvalho Chehab mche...@infradead.org

Acked-by: Marek Szyprowski m.szyprow...@samsung.com

 ---
 
 diff --git a/drivers/media/video/videobuf2-dma-contig.c 
 b/drivers/media/video/videobuf2-dma-
 contig.c
 index f17ad98..a1bee6c 100644
 --- a/drivers/media/video/videobuf2-dma-contig.c
 +++ b/drivers/media/video/videobuf2-dma-contig.c
 @@ -15,6 +15,7 @@
  #include linux/dma-mapping.h
 
  #include media/videobuf2-core.h
 +#include media/videobuf2-dma-contig.h
  #include media/videobuf2-memops.h
 
  struct vb2_dc_conf {

Best regards
-- 
Marek Szyprowski
Samsung Poland RD Center

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] media: videobuf2-dma-contig: include header for exported symbols

[H Hartley Sweeten]

Include the header to pickup the definitions of the exported symbols.

Quiets the following sparse warnings:

warning: symbol 'vb2_dma_contig_memops' was not declared. Should it be static?
warning: symbol 'vb2_dma_contig_init_ctx' was not declared. Should it be static?
warning: symbol 'vb2_dma_contig_cleanup_ctx' was not declared. Should it be 
static?

Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Pawel Osciak pa...@osciak.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Mauro Carvalho Chehab mche...@infradead.org

---

diff --git a/drivers/media/video/videobuf2-dma-contig.c 
b/drivers/media/video/videobuf2-dma-contig.c
index f17ad98..a1bee6c 100644
--- a/drivers/media/video/videobuf2-dma-contig.c
+++ b/drivers/media/video/videobuf2-dma-contig.c
@@ -15,6 +15,7 @@
 #include linux/dma-mapping.h
 
 #include media/videobuf2-core.h
+#include media/videobuf2-dma-contig.h
 #include media/videobuf2-memops.h
 
 struct vb2_dc_conf {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html