Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2018-11-07 Thread Hyun Kwon
Hi Akinobu, Thanks for the patch. On Sun, 2018-11-04 at 05:11:10 -0800, Akinobu Mita wrote: > The fwnode_graph_get_next_endpoint() returns an 'endpoint' node pointer > with refcount incremented, and refcount of the passed as a previous > 'endpoint' node is decremented. > > So when iterating

[PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2018-11-04 Thread Akinobu Mita
The fwnode_graph_get_next_endpoint() returns an 'endpoint' node pointer with refcount incremented, and refcount of the passed as a previous 'endpoint' node is decremented. So when iterating over all nodes using fwnode_graph_get_next_endpoint(), we don't need to call fwnode_handle_put() for each

Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2017-12-11 Thread Laurent Pinchart
Hi Akinobu, Thank you for the patch. On Thursday, 12 October 2017 19:04:44 EET Akinobu Mita wrote: > When iterating through all endpoints using of_graph_get_next_endpoint(), > the refcount of the returned endpoint node is incremented and the refcount > of the node which is passed as previous

[PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2017-10-12 Thread Akinobu Mita
When iterating through all endpoints using of_graph_get_next_endpoint(), the refcount of the returned endpoint node is incremented and the refcount of the node which is passed as previous endpoint is decremented. So the caller doesn't need to call of_node_put() for each iterated node except for