Re: [PATCH] quickcam_messenger.c: add support for all quickcam Messengers of the same family
On 21:33 Sun 16 Aug 2009, Mauro Carvalho Chehab wrote: > Could you please check if stv06xx.c is properly working with those devices? > Feel free to submit patches improving it, if needed. Alright, I asked the two users who reported the bug to test gspca_stv06xx.ko also. I will let you know how that goes. Cheers, Brandon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] quickcam_messenger.c: add support for all quickcam Messengers of the same family
Em Fri, 7 Aug 2009 18:21:35 -0700
Brandon Philips escreveu:
> Hey Mauro-
>
> I sent this patch long ago and it seemed to have gotten lost along the
> way.
>
> Jaya acked the patch so it is in my mercurial tree now:
>
> http://ifup.org/hg/v4l-dvb/
> http://ifup.org/hg/v4l-dvb/rev/335a6ccbacb3
>
> Please pull the patch when you get a chance.
> Index: linux-2.6/drivers/media/video/usbvideo/quickcam_messenger.c
> static struct usb_device_id qcm_table [] = {
> - { USB_DEVICE(USB_LOGITECH_VENDOR_ID, USB_QCM_PRODUCT_ID) },
> + { USB_DEVICE(0x046D, 0x08F0) }, /* QuickCam Messenger */
> + { USB_DEVICE(0x046D, 0x08F5) }, /* QuickCam Communicate */
> + { USB_DEVICE(0x046D, 0x08F6) }, /* QuickCam Messenger (new) */
> + { USB_DEVICE(0x046D, 0x08DA) }, /* QuickCam Messenger (new) */
Hmm... this module is obsolete, as I explained at:
http://lkml.org/lkml/2009/6/23/56
There's also a patch proposing its removal for 2.6.32:
http://patchwork.kernel.org/patch/33734/
(somehow, it seems that this were incorrectly unqueued. I'll add it on my next
upstream series of patches)
As support for QuickCam were already added at gspca and this module is V4L1, it
will be soon deprecated/removed from kernel. So, it would be good to test if
all those variants are supported by stv06xx.c. From its table, we have:
static const __devinitdata struct usb_device_id device_table[] = {
/* QuickCam Express */
{USB_DEVICE(0x046d, 0x0840), .driver_info = BRIDGE_STV600 },
/* LEGO cam / QuickCam Web */
{USB_DEVICE(0x046d, 0x0850), .driver_info = BRIDGE_STV610 },
/* Dexxa WebCam USB */
{USB_DEVICE(0x046d, 0x0870), .driver_info = BRIDGE_STV602 },
/* QuickCam Messenger */
{USB_DEVICE(0x046D, 0x08F0), .driver_info = BRIDGE_ST6422 },
/* QuickCam Communicate */
{USB_DEVICE(0x046D, 0x08F5), .driver_info = BRIDGE_ST6422 },
/* QuickCam Messenger (new) */
{USB_DEVICE(0x046D, 0x08F6), .driver_info = BRIDGE_ST6422 },
/* QuickCam Messenger (new) */
{USB_DEVICE(0x046D, 0x08DA), .driver_info = BRIDGE_ST6422 },
{}
So, I suspect that everything is there already.
Jaya,
Could you please check if stv06xx.c is properly working with those devices?
Feel free to submit patches improving it, if needed.
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] quickcam_messenger.c: add support for all quickcam Messengers of the same family
Hi Brandon, Em Fri, 7 Aug 2009 18:21:35 -0700 Brandon Philips escreveu: > Hey Mauro- > > I sent this patch long ago and it seemed to have gotten lost along the > way. > > Jaya acked the patch so it is in my mercurial tree now: > > http://ifup.org/hg/v4l-dvb/ > http://ifup.org/hg/v4l-dvb/rev/335a6ccbacb3 > > Please pull the patch when you get a chance. Please add a [PULL] tag on pull requests, for it to be properly catched by my scripts. If you add [PATCH] instead, it will be moved to a special inbox that I generally read only when analyzing Patchwork queue. In this specific case, as your email doesn't have any patch, it will be silently ignored by Patchwork. So, sending it like this is close to send it to /dev/null :) Anyway, I've re-queued your pull request to my pile of pull's. I'll be handling it shortly. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] quickcam_messenger.c: add support for all quickcam Messengers of the same family
On 18:21 Fri 07 Aug 2009, Brandon Philips wrote: > I sent this patch long ago and it seemed to have gotten lost along the > way. > > Jaya acked the patch so it is in my mercurial tree now: > > http://ifup.org/hg/v4l-dvb/ > http://ifup.org/hg/v4l-dvb/rev/335a6ccbacb3 > > Please pull the patch when you get a chance. Is there something wrong with this patch? I see it still hasn't hit v4l-dvb. Thanks, Brandon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] quickcam_messenger.c: add support for all quickcam Messengers of the same family
Hey Mauro-
I sent this patch long ago and it seemed to have gotten lost along the
way.
Jaya acked the patch so it is in my mercurial tree now:
http://ifup.org/hg/v4l-dvb/
http://ifup.org/hg/v4l-dvb/rev/335a6ccbacb3
Please pull the patch when you get a chance.
Thanks,
Brandon
On 14:38 Tue 02 Dec 2008, bphil...@suse.de wrote:
> Add three devices that are supported by out of tree drivers to the
> quickcam_messenger driver. Also, remove the sensor_id check since it seems to
> just check the PID.
>
> The quickcam messenger plus (0x08F6) is supported by Christian's out of tree
> driver[1] but two users have confirmed that the in tree quickcam_messenger
> driver works for their devices if the IDs are added:
>
> https://bugzilla.novell.com/show_bug.cgi?id=441650#c3
>
> https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.15/+bug/22070/comments/33
>
> https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.15/+bug/22070/comments/34
>
> If Christian or Jaya sign off I think this should be merged.
>
> [1] http://home.mag.cx/messenger/source/
>
> Signed-off-by: Brandon Philips
>
> ---
> drivers/media/video/usbvideo/quickcam_messenger.c | 13 -
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> Index: linux-2.6/drivers/media/video/usbvideo/quickcam_messenger.c
> ===
> --- linux-2.6.orig/drivers/media/video/usbvideo/quickcam_messenger.c
> +++ linux-2.6/drivers/media/video/usbvideo/quickcam_messenger.c
> @@ -56,9 +56,6 @@ static const int debug;
> #define DRIVER_VERSION "v0.01"
> #define DRIVER_DESC "Logitech Quickcam Messenger USB"
>
> -#define USB_LOGITECH_VENDOR_ID 0x046D
> -#define USB_QCM_PRODUCT_ID 0x08F0
> -
> #define MAX_CAMERAS 1
>
> #define MAX_COLOUR 32768
> @@ -77,7 +74,10 @@ static int whiteness = MAX_WHITENESS;
> static struct usbvideo *cams;
>
> static struct usb_device_id qcm_table [] = {
> - { USB_DEVICE(USB_LOGITECH_VENDOR_ID, USB_QCM_PRODUCT_ID) },
> + { USB_DEVICE(0x046D, 0x08F0) }, /* QuickCam Messenger */
> + { USB_DEVICE(0x046D, 0x08F5) }, /* QuickCam Communicate */
> + { USB_DEVICE(0x046D, 0x08F6) }, /* QuickCam Messenger (new) */
> + { USB_DEVICE(0x046D, 0x08DA) }, /* QuickCam Messenger (new) */
> { }
> };
> MODULE_DEVICE_TABLE(usb, qcm_table);
> @@ -998,11 +998,6 @@ good_videoep:
> err("Couldn't read sensor values. Err %d\n",err);
> return err;
> }
> - if (sensor_id != cpu_to_le16(0x08F0)) {
> - err("Sensor ID %x != %x. Unsupported. Sorry\n",
> - le16_to_cpu(sensor_id), (0x08F0));
> - return -ENODEV;
> - }
>
> uvd = usbvideo_AllocateDevice(cams);
> if (!uvd)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
