Re: [PATCH] staging: atomisp: potential underflow in atomisp_get_metadata_by_type()

2017-03-13 Thread Alan Cox
On Mon, 2017-03-13 at 15:34 +0300, Dan Carpenter wrote: > md_type is an enum.  On my tests, GCC treats it as unsigned but > according to the C standard it's an implementation dependant thing so > we > should check for negatives. Can do but the kernel assumes GNU C everywhere else. Acked-by: Alan

[PATCH] staging: atomisp: potential underflow in atomisp_get_metadata_by_type()

2017-03-13 Thread Dan Carpenter
md_type is an enum. On my tests, GCC treats it as unsigned but according to the C standard it's an implementation dependant thing so we should check for negatives. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter