Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
On 03/24/14 18:51, Lad, Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Documentation/video4linux/v4l2-pci-skeleton.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c index 3a1c0d2..61a56f4 100644 --- a/Documentation/video4linux/v4l2-pci-skeleton.c +++ b/Documentation/video4linux/v4l2-pci-skeleton.c @@ -87,7 +87,7 @@ struct skel_buffer { static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2) { - return container_of(vb2, struct skel_buffer, vb); + return container_of(vb2, struct skel_buffer, vb2); Why is this a type? The vb2_buffer member in struct skel_buffer is called 'vb', so this should be correct. Regards, Hans } static const struct pci_device_id skeleton_pci_tbl[] = { -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
Hi Hans, On Wed, Apr 2, 2014 at 3:08 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 03/24/14 18:51, Lad, Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Documentation/video4linux/v4l2-pci-skeleton.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c index 3a1c0d2..61a56f4 100644 --- a/Documentation/video4linux/v4l2-pci-skeleton.c +++ b/Documentation/video4linux/v4l2-pci-skeleton.c @@ -87,7 +87,7 @@ struct skel_buffer { static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2) { - return container_of(vb2, struct skel_buffer, vb); + return container_of(vb2, struct skel_buffer, vb2); Why is this a type? The vb2_buffer member in struct skel_buffer is called 'vb', so this should be correct. Oops may be I overlooked, sorry for the noise. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Documentation/video4linux/v4l2-pci-skeleton.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c index 3a1c0d2..61a56f4 100644 --- a/Documentation/video4linux/v4l2-pci-skeleton.c +++ b/Documentation/video4linux/v4l2-pci-skeleton.c @@ -87,7 +87,7 @@ struct skel_buffer { static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2) { - return container_of(vb2, struct skel_buffer, vb); + return container_of(vb2, struct skel_buffer, vb2); } static const struct pci_device_id skeleton_pci_tbl[] = { -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html