Re: [PATCH -next] media: imx-pxp: remove duplicated include from imx-pxp.c

On Sat, 2018-10-06 at 07:36 +, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/media/platform/imx-pxp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/imx-pxp.c > b/drivers/media/platform/imx-pxp.c > index

[PATCH -next] media: imx-pxp: remove duplicated include from imx-pxp.c

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/media/platform/imx-pxp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c index b76cd0e..229c23a 100644 --- a/drivers/media/platform/imx-pxp.c +++

[PATCH -next] [media] media: drop pointless static qualifier in vpfe_ipipeif_init()

There is no need to have the 'resource_size_t res_len' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] [media] media: drop pointless static qualifier in vpfe_resizer_init()

There is no need to have the 'resource_size_t res_len' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] media: dvb-usb-v2/gl861: Use kmemdup rather than duplicating its implementation in gl861_i2c_write_ex

Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/media/usb/dvb-usb-v2/gl861.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/gl861.c b/drivers/media/usb/dvb-usb-v2/gl861.c index 0559417..80fed44

[PATCH -next] media: tvp5150: make function tvp5150_volatile_reg() static

Fixes the following sparse warning: drivers/media/i2c/tvp5150.c:1457:6: warning: symbol 'tvp5150_volatile_reg' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH -next] media/platform/cadence: add to fix build error

On Fri, Jun 08, 2018 at 02:19:06PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Add #include to fix build errors. > This driver uses kzalloc() and kfree() so it needs to #include > the appropriate header file for those interfaces. > > Fixes these build errors: > >

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

Hi Sakari, On 04/30/2018 10:15 AM, Sakari Ailus wrote: Isn't there a guarantee that new_buf won't be NULL ? The new_buf pointer comes from the parg variable in video_usercopy(), which should always point to a valid buffer given that the ioctl number specifies a non-zero size. Fair question.

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

On Thu, Apr 26, 2018 at 01:03:15PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday, 26 April 2018 11:37:31 EEST Sakari Ailus wrote: > > On Tue, Apr 24, 2018 at 02:06:18PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > The pointer user_cfg

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

Hi Sakari, On Thursday, 26 April 2018 11:37:31 EEST Sakari Ailus wrote: > On Tue, Apr 24, 2018 at 02:06:18PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The pointer user_cfg (a copy of new_conf) is dereference before > > new_conf is null checked, hence we

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

On Tue, Apr 24, 2018 at 02:06:18PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer user_cfg (a copy of new_conf) is dereference before > new_conf is null checked, hence we may have a null pointer dereference > on user_cfg when assigning buf_size from

[PATCH][next] media: ispstat: don't dereference user_cfg before a null check

From: Colin Ian King The pointer user_cfg (a copy of new_conf) is dereference before new_conf is null checked, hence we may have a null pointer dereference on user_cfg when assigning buf_size from user_cfg->buf_size. Ensure this does not occur by moving the assignment

Re: [PATCH-next] media: s2255drv: Remove unneeded if else blocks

Am 24.01.2018 22:40, schrieb Christopher Díaz Riveros: > Given the following definitions from s2255drv.c > > #define LINE_SZ_4CIFS_NTSC 640 > #define LINE_SZ_2CIFS_NTSC 640 > #define LINE_SZ_1CIFS_NTSC 320 > > and > > #define LINE_SZ_4CIFS_PAL 704 > #define

[PATCH-next] media: s2255drv: Remove unneeded if else blocks

Given the following definitions from s2255drv.c #define LINE_SZ_4CIFS_NTSC 640 #define LINE_SZ_2CIFS_NTSC 640 #define LINE_SZ_1CIFS_NTSC 320 and #define LINE_SZ_4CIFS_PAL 704 #define LINE_SZ_2CIFS_PAL 704 #define LINE_SZ_1CIFS_PAL 352 f->fmt.pix.width

RE: [PATCH -next] media: rcar_drif: fix error return code in rcar_drif_alloc_dmachannels()

Hi Wei Yongjun, Thank you for the patch. > Subject: [PATCH -next] media: rcar_drif: fix error return code in > rcar_drif_alloc_dmachannels() > > Fix to return error code -ENODEV from the dma_request_slave_channel() > error handling case instead of 0, as done elsewhere in this fun

Re: [PATCH -next] media: rcar_drif: fix error return code in rcar_drif_alloc_dmachannels()

On Wed, Jan 17, 2018 at 12:24 PM, Wei Yongjun wrote: > Fix to return error code -ENODEV from the dma_request_slave_channel() > error handling case instead of 0, as done elsewhere in this function. > rc can be overwrite to 0 by dmaengine_slave_config() in the for loop. > >

Re: [PATCH -next] media: rcar_drif: fix error return code in rcar_drif_alloc_dmachannels()

Hello! On 01/17/2018 02:24 PM, Wei Yongjun wrote: Fix to return error code -ENODEV from the dma_request_slave_channel() error handling case instead of 0, as done elsewhere in this function. rc can be overwrite to 0 by dmaengine_slave_config() in the for loop. Overwritten. Signed-off-by:

[PATCH -next] media: rcar_drif: fix error return code in rcar_drif_alloc_dmachannels()

Fix to return error code -ENODEV from the dma_request_slave_channel() error handling case instead of 0, as done elsewhere in this function. rc can be overwrite to 0 by dmaengine_slave_config() in the for loop. Signed-off-by: Wei Yongjun ---

Re: [PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static

On 2017/12/23 9:57, Wei Yongjun wrote: Fixes the following sparse warning: drivers/media/platform/atmel/atmel-isc.c:338:19: warning: symbol 'fmt_configs_list' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- Acked-by: Wenyou Yang

[PATCH -next] media: atmel-isc: Make local symbol fmt_configs_list static

Fixes the following sparse warning: drivers/media/platform/atmel/atmel-isc.c:338:19: warning: symbol 'fmt_configs_list' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1

[PATCH][next] media: lirc: don't kfree the uninitialized pointer txbuf

From: Colin Ian King The current error exit path if ir_raw_encode_scancode fails is via the label out_kfree which kfree's an uninitialized pointer txbuf. Fix this by exiting via a new exit path that does not kfree txbuf. Also exit via this new exit path for a failed

Re: [PATCH -next] media: ov5670: add depends to fix build errors

On Thu, Jul 20, 2017 at 04:47:38PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors by adding dependency on VIDEO_V4L2_SUBDEV_API: Thanks for the patch, Randy, but I've already applied Arnd's patch with very similar content. -- Sakari Ailus e-mail:

[PATCH -next] media: ov5670: add depends to fix build errors

From: Randy Dunlap Fix build errors by adding dependency on VIDEO_V4L2_SUBDEV_API: ../drivers/media/i2c/ov5670.c: In function 'ov5670_open': ../drivers/media/i2c/ov5670.c:1917:5: error: implicit declaration of function 'v4l2_subdev_get_try_format'

[PATCH -next] [media] s5p-cec: remove unused including

From: Wei Yongjun Remove including that is not needed. Signed-off-by: Wei Yongjun --- drivers/media/platform/s5p-cec/s5p_cec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/s5p-cec/s5p_cec.h

[PATCH -next] [media] rainshadow-cec: Fix missing spin_lock_init()

From: Wei Yongjun The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI CEC driver")

[PATCH -next] media/platform/mtk-jpeg: add slab.h to fix build errors

From: Randy Dunlap Include to fix these build errors: ../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function 'mtk_jpeg_open': ../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:2: error: implicit declaration of function 'kzalloc'

Re: [PATCH -next] [media] mtk-vcodec: remove redundant return value check of platform_get_resource()

On Tue, 2017-02-07 at 15:16 +, Wei Yongjun wrote: > From: Wei Yongjun > > Remove unneeded error handling on the result of a call > to platform_get_resource() when the value is passed to > devm_ioremap_resource(). > > Signed-off-by: Wei Yongjun

[PATCH -next] [media] mtk-vcodec: remove redundant return value check of platform_get_resource()

From: Wei Yongjun Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource(). Signed-off-by: Wei Yongjun --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 5

[PATCH -next] [media] media: usb: tm6000: fix typo in parameter description

From: Wei Yongjun Fix typo in parameter description. Signed-off-by: Wei Yongjun --- drivers/media/usb/tm6000/tm6000-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-input.c

[PATCH -next] [media] atmel-isc: fix error return code in atmel_isc_probe()

From: Wei Yongjun Fix to return error code -ENODEV from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/atmel/atmel-isc.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH -next] [media] c8sectpfe: fix error return code in c8sectpfe_probe()

On 10/30/2016 02:53 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENODEV from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- >

[PATCH -next] [media] c8sectpfe: fix error return code in c8sectpfe_probe()

From: Wei Yongjun Fix to return error code -ENODEV from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 ++ 1 file changed, 2

[PATCH -next] [media] dibusb: fix possible memory leak in dibusb_rc_query()

From: Wei Yongjun 'buf' is malloced in dibusb_rc_query() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: ff1c123545d7 ("[media] dibusb: handle error code on RC query") Signed-off-by: Wei Yongjun

[PATCH -next] [media] dibusb: fix possible memory leak in dibusb_rc_query()

From: Wei Yongjun 'buf' is malloced in dibusb_rc_query() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: ff1c123545d7 ("[media] dibusb: handle error code on RC query") Signed-off-by: Wei Yongjun

[PATCH -next] [media] s5p-cec: remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/staging/media/s5p-cec/s5p_cec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c

Re: [PATCH -next] [media] bdisp: fix error return code in bdisp_probe()

Hi Wei, Thank you for the patch. On 09/21/2016 05:09 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -EINVAL from the platform_get_resource() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun

[PATCH -next] [media] cx88: fix error return code in cx8802_dvb_probe()

From: Wei Yongjun Fix to return error code -ENODEV from the error handling case instead of 0(err maybe overwrited to 0 in the for loop), as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/pci/cx88/cx88-dvb.c | 1 +

[PATCH -next] [media] bdisp: fix error return code in bdisp_probe()

From: Wei Yongjun Fix to return error code -EINVAL from the platform_get_resource() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 + 1 file

[PATCH -next] [media] gs1662: remove .owner field for driver

From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun --- drivers/media/spi/gs1662.c | 1 - 1 file changed, 1 deletion(-)

[PATCH -next] [media] gs1662: drop kfree for memory allocated with devm_kzalloc

From: Wei Yongjun It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 7aae6e2df127 ("[media] Add GS1662 driver, a video serializer") Signed-off-by: Wei Yongjun ---

Re: [PATCH -next] [media] pxa_camera: remove duplicated include from pxa_camera.c

Wei Yongjun writes: > From: Wei Yongjun > > Remove duplicated include. > > Signed-off-by: Wei Yongjun Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line

Re: [PATCH -next] [media] pxa_camera: fix error return code in pxa_camera_probe()

Wei Yongjun writes: > From: Wei Yongjun > > Fix to return error code -ENODEV from dma_request_slave_channel_compat() > error handling case instead of 0, as done elsewhere in this function. > > Also fix to release resources in v4l2_clk_register() error

[PATCH -next] [media] vivid: fix error return code in vivid_create_instance()

From: Wei Yongjun Fix to return error code -ENOMEM from the memory or workqueue alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/platform/vivid/vivid-core.c | 5 - 1

[PATCH -next] [media] pxa_camera: remove duplicated include from pxa_camera.c

From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- drivers/media/platform/pxa_camera.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index

[PATCH -next] [media] pxa_camera: fix error return code in pxa_camera_probe()

From: Wei Yongjun Fix to return error code -ENODEV from dma_request_slave_channel_compat() error handling case instead of 0, as done elsewhere in this function. Also fix to release resources in v4l2_clk_register() error handling. Signed-off-by: Wei Yongjun

[PATCH -next] [media] adv7511: fix error return code in adv7511_probe()

Fix to return error code -ENOMEM from the i2c client register error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/i2c/adv7511.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/adv7511.c

[PATCH -next] [media] staging: media: lirc: add missing platform_device_del() on error in lirc_parallel_init()

From: Wei Yongjun Add the missing platform_device_del() before return from lirc_parallel_init() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/staging/media/lirc/lirc_parallel.c | 10 ++ 1 file changed,

Re: [PATCH next] [media] vb2: Fix allocation size of dma_parms

Hi On 2016-07-18 19:54, Vincent Stehlé wrote: When allocating memory to hold the device dma parameters in vb2_dma_contig_set_max_seg_size(), the requested size is by mistake only the size of a pointer. Request the correct size instead. Fixes: 3f0339691896 ("media: vb2-dma-contig: add helper

[PATCH next] [media] vb2: Fix allocation size of dma_parms

When allocating memory to hold the device dma parameters in vb2_dma_contig_set_max_seg_size(), the requested size is by mistake only the size of a pointer. Request the correct size instead. Fixes: 3f0339691896 ("media: vb2-dma-contig: add helper for setting dma max seg size") Signed-off-by:

[PATCH -next] [media] pulse8-cec: fix non static symbol warning

From: Wei Yongjun Fixes the following sparse warning: drivers/staging/media/pulse8-cec/pulse8-cec.c:427:27: warning: symbol 'pulse8_cec_adap_ops' was not declared. Should it be static? Signed-off-by: Wei Yongjun ---

[PATCH -next] [media] rcar_vin: remove redundant return value check of platform_get_resource()

From: Wei Yongjun Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource(). And move those two call together to make the connection between them more clear. Signed-off-by: Wei Yongjun

Re: [PATCH -next] [media] rcar_jpu: Add missing clk_disable_unprepare() on error in jpu_open()

On Tue, Jul 12, 2016 at 2:21 PM, wrote: > From: Wei Yongjun > > Add the missing clk_disable_unprepare() before return from > jpu_open() in the software reset error handling case. > > Signed-off-by: Wei Yongjun

[PATCH -next] [media] mtk-vcodec: remove .owner field for driver

From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun ---

[PATCH -next] [media] s5p-mfc: remove redundant return value check of platform_get_resource()

From: Wei Yongjun Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource(). Signed-off-by: Wei Yongjun --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4

Re: [PATCH -next] [media] mtk-vcodec: remove redundant dev_err call in mtk_vcodec_probe()

Reviewed-by: Tiffany Lin On Tue, 2016-07-12 at 11:02 +, weiyj...@163.com wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. >

[PATCH -next] [media] rcar_jpu: Add missing clk_disable_unprepare() on error in jpu_open()

From: Wei Yongjun Add the missing clk_disable_unprepare() before return from jpu_open() in the software reset error handling case. Signed-off-by: Wei Yongjun --- drivers/media/platform/rcar_jpu.c | 4 +++- 1 file changed, 3

Re: [PATCH -next] [media] vcodec: mediatek: Fix return value check in mtk_vcodec_init_enc_pm()

Reviewed-by:Tiffany Lin On Tue, 2016-07-12 at 11:02 +, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and not returns NULL. The NULL test in the return value check >

[PATCH -next] [media] vcodec: mediatek: Fix return value check in mtk_vcodec_init_enc_pm()

From: Wei Yongjun In case of error, the function devm_clk_get() returns ERR_PTR() and not returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun ---

[PATCH -next] [media] mtk-vcodec: remove redundant dev_err call in mtk_vcodec_probe()

From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 2

[PATCH -next] [media] VPU: mediatek: fix return value check in mtk_vpu_probe()

From: Wei Yongjun In case of error, the function devm_clk_get() returns ERR_PTR() and not returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun ---

[PATCH -next] [media] VPU: mediatek: remove redundant dev_err call in mtk_vpu_probe()

From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 8 ++-- 1

[PATCH] next: media: cx231xx: add #ifdef to fix compile error

Compiling linux-next gave this warning: drivers/media/usb/cx231xx/cx231xx-cards.c: In function ‘cx231xx_usb_probe’: drivers/media/usb/cx231xx/cx231xx-cards.c:1754:36: error: ‘struct cx231xx’ has no member named ‘media_dev’ retval = media_device_register(dev->media_dev); Looking at the

Re: [PATCH] next: media: cx231xx: add #ifdef to fix compile error

Hello Okash, On 12/22/2015 07:27 AM, Okash Khawaja wrote: > Compiling linux-next gave this warning: > > drivers/media/usb/cx231xx/cx231xx-cards.c: In function > ‘cx231xx_usb_probe’: > drivers/media/usb/cx231xx/cx231xx-cards.c:1754:36: error: ‘struct > cx231xx’ has no member named ‘media_dev’ >

Re: [PATCH] next: media: cx231xx: add #ifdef to fix compile error

On Tue, Dec 22, 2015 at 09:46:19AM -0300, Javier Martinez Canillas wrote: > Hello Okash, > > On 12/22/2015 07:27 AM, Okash Khawaja wrote: > > Compiling linux-next gave this warning: > > > > drivers/media/usb/cx231xx/cx231xx-cards.c: In function > > ‘cx231xx_usb_probe’: > >

Re: [PATCH] next: media: cx231xx: add #ifdef to fix compile error

Hello Okash, On 12/22/2015 10:00 AM, Okash Khawaja wrote: [snip] > > Cool. There was another similar compile error > > https://lkml.org/lkml/2015/12/22/196 > Yes and you can see in that thread that I also mention that was fixed already :) > Thanks, > Okash > Best regards, -- Javier

Re: [PATCH] next: media: cx231xx: add #ifdef to fix compile error

> On 22 Dec 2015, at 13:08, Javier Martinez Canillas > wrote: > > Hello Okash, > > On 12/22/2015 10:00 AM, Okash Khawaja wrote: > > [snip] > >> >> Cool. There was another similar compile error >> >> https://lkml.org/lkml/2015/12/22/196 > > Yes and you can see in

[PATCH -next] media/pci/cobalt: fix Kconfig and build when SND is not enabled

From: Randy Dunlap rdun...@infradead.org Fix build errors in cobalt driver when CONFIG_SND is not enabled. Fixes these build errors: ERROR: snd_pcm_period_elapsed [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: _snd_pcm_stream_lock_irqsave [drivers/media/pci/cobalt/cobalt.ko] undefined!

[PATCH -next] media/dvb: fix ts2020.c Kconfig and build

From: Randy Dunlap rdun...@infradead.org Fix kconfig warning that is caused by DVB_TS2020: warning: (DVB_TS2020 SND_SOC_ADAU1761_I2C SND_SOC_ADAU1781_I2C SND_SOC_ADAU1977_I2C SND_SOC_RT5677 EXTCON_MAX14577 EXTCON_MAX77693 EXTCON_MAX77843) selects REGMAP_I2C which has unmet direct

Re: [PATCH -next] media: tw68: fix build errors and warnings

Hi Randy, After analyzing this it became clear that the I2C_ALGOBIT select was bogus since this driver doesn't use i2c at all. I've posted a new patch fixing that. Thanks, Hans On 10/06/2014 07:05 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix build errors and

[PATCH -next] media: tw68: fix build errors and warnings

From: Randy Dunlap rdun...@infradead.org Fix build errors and kconfig warning: since 'select' does not check Kconfig symbol dependencies, add that dependency explicitly. VIDEO_TW68 selects I2C_ALGOBIT, so it should depend on I2C to prevent build errors and warnings. warning: (CAN_PEAK_PCIEC

[PATCH -next] media/radio: fix radio-miropcm20.c build with io.h header file

From: Randy Dunlap rdun...@infradead.org Fix build errors in radio-miropcm20.c due to missing header file: drivers/media/radio/radio-miropcm20.c: In function 'rds_waitread': drivers/media/radio/radio-miropcm20.c:90:3: error: implicit declaration of function 'inb'

[PATCH -next] [media] radio-miropcm20: fix sparse NULL pointer warning

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warnings: drivers/media/radio/radio-miropcm20.c:193:33: warning: Using plain integer as NULL pointer Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/radio/radio-miropcm20.c | 2 +- 1 file

[PATCH -next] [media] radio-usb-si4713: fix sparse non static symbol warnings

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warnings: drivers/media/radio/si4713/radio-usb-si4713.c:226:31: warning: symbol 'start_seq' was not declared. Should it be static? drivers/media/radio/si4713/radio-usb-si4713.c:291:29: warning: symbol 'command_table'

[PATCH -next] [media] au0828: Fix sparse non static symbol warning

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warning: drivers/media/usb/au0828/au0828-dvb.c:36:5: warning: symbol 'preallocate_big_buffers' was not declared. Should it be static? Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

[PATCH -next] [media] em28xx-audio: remove needless check before usb_free_coherent()

From: Wei Yongjun yongjun_...@trendmicro.com.cn usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/usb/em28xx/em28xx-audio.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

[PATCH -next] [media] radio-bcm2048: fix missing unlock on error in bcm2048_rds_fifo_receive()

From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function bcm2048_rds_fifo_receive() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/staging/media/bcm2048/radio-bcm2048.c | 1 + 1 file changed, 1

Re: [PATCH -next] [media] media: i2c: lm3560: fix missing unlock error in lm3560_get_ctrl().

Hi Daniel, Thanks for the patch. (Dropping LKML; this isn't relevant there.) On Thu, Nov 14, 2013 at 12:43:27PM +0900, Daniel Jeong wrote: Add the missing unlock before return from function lm3560_get_ctrl() to avoid deadlock. Thanks to Dan Carpenter. Signed-off-by: Daniel Jeong

[PATCH -next] [media] media: i2c: lm3560: fix missing unlock error in lm3560_get_ctrl().

Add the missing unlock before return from function lm3560_get_ctrl() to avoid deadlock. Thanks to Dan Carpenter. Signed-off-by: Daniel Jeong gshark.je...@gmail.com --- drivers/media/i2c/lm3560.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH -next] [media] media: i2c: lm3560: fix missing unlock on error in lm3560_set_ctrl()

From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function lm3560_set_ctrl() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/i2c/lm3560.c | 14 +- 1 file changed, 9 insertions(+), 5

Re: [PATCH -next] [media] v4l: ti-vpe: fix return value check in vpe_probe()

On Wednesday 30 October 2013 08:45 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_kzalloc() and devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.

Re: [PATCH -next] [media] v4l: ti-vpe: fix return value check in vpe_probe()

On Wednesday 30 October 2013 08:45 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_kzalloc() and devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.

Re: [PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe()

On Wednesday 30 October 2013 08:40 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Reviewed-by: Archit Taneja arc...@ti.com Thanks, Archit

[patch -next] [media] cx231xx: use after free on error path in probe

We dereference dev after it has already been freed. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index e9d017b..528cce9 100644 --- a/drivers/media/usb/cx231xx/cx231xx-cards.c +++

[PATCH -next] media/platform/marvell-ccic: fix cafe_ccic build error

From: Randy Dunlap rdun...@infradead.org The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent build errors. drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x14643e): undefined reference to

Re: [PATCH -next] media/platform/marvell-ccic: fix cafe_ccic build error

On Thu, 31 Oct 2013 11:07:28 -0700 Randy Dunlap rdun...@infradead.org wrote: From: Randy Dunlap rdun...@infradead.org The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent build errors. Geert sent a patch too a little

[PATCH -next] [media] v4l: ti-vpe: use module_platform_driver to simplify the code

From: Wei Yongjun yongjun_...@trendmicro.com.cn module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/ti-vpe/vpe.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-)

[PATCH -next] [media] v4l: ti-vpe: fix error return code in vpe_probe()

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/ti-vpe/vpe.c | 4 +++- 1 file changed, 3

[PATCH -next] [media] v4l: ti-vpe: fix return value check in vpe_probe()

From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_kzalloc() and devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] [media] davinci: vpif_capture: fix error return code in vpif_probe()

Hi Wei, On Fri, Aug 23, 2013 at 8:50 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Wei, I retract my Ack. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error

[PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe()

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduce by commit 4b8a531e6bb0686203e9cf82a54dfe189de7d5c2. ([media] media: davinci: vpif: display: add V4L2-async support)

[PATCH -next] [media] davinci: vpif_capture: fix error return code in vpif_probe()

From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba ([media] media: davinci: vpif: capture: add V4L2-async support)

Re: [PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe()

Hi Wei, On Fri, Aug 23, 2013 at 8:29 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduce by commit

Re: [PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe()

Hi Wei On Fri, Aug 23, 2013 at 8:39 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Wei, On Fri, Aug 23, 2013 at 8:29 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead

Re: [PATCH -next] [media] davinci: vpif_capture: fix error return code in vpif_probe()

Hi Wei, Thanks for the patch. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduced by commit

Re: [PATCH -next] [media] davinci: vpif_capture: fix error return code in vpif_probe()

Hi Wei, I retract my Ack. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduced by commit

RE: [PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe()

-Original Message- From: Prabhakar Lad [mailto:prabhakar.cse...@gmail.com] Sent: 2013年8月23日 11:10 To: Wei Yongjun Cc: Mauro Carvalho Chehab; Yongjun Wei (RD-CN); linux-media; dlos Subject: Re: [PATCH -next] [media] davinci: vpif_display: fix error return code in vpif_probe() Hi Wei

Re: [PATCH -next] [media] usbtv: remove unused including linux/version.h

On Wed, 2013-07-17 at 10:01 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including linux/version.h that don't need it. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Lubomir Rintel lkund...@v3.sk -- To unsubscribe from this list:

[PATCH -next] [media] usbtv: remove unused including linux/version.h

From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including linux/version.h that don't need it. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/usb/usbtv/usbtv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/usbtv/usbtv.c

Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()

Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function coda_stop_streaming() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()

On 06/18/2013 06:03 PM, Philipp Zabel wrote: Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function coda_stop_streaming() in the error handling case. Signed-off-by: Wei Yongjun

  1   2   >