Re: [PATCH 0/2] gspca sn9c20x subdriver rev2

2009-07-18 Thread Jean-Francois Moine
On Fri, 17 Jul 2009 16:51:41 -0400 Brian Johnson brij...@gmail.com wrote: Mauro, Here is the updated version of the gspca sn9c20x subdriver. I've removed the custom debugging support and replaced it with support for the v4l2 debugging ioctls. The first patch in this set adds support to the

Re: [PATCH 0/2] gspca sn9c20x subdriver rev2

2009-07-18 Thread Brian Johnson
- in the 1st patch, in gspca.c, why is the get_chip_ident check needed in vidioc_g_register / vidioc_s_register)? According the the current v4l2 spec regarding the set and get register ioctls drivers that support them must also support the get chip ident ioctl. As such in the

Re: [PATCH 0/2] gspca sn9c20x subdriver rev2

2009-07-18 Thread leandro Costantino
Hi, shouldn't there be a check when allocating jpg_hdr? or i am missing something? sd-jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); jpeg_define(sd-jpeg_hdr, height, width, 0x21); jpeg_set_qual(sd-jpeg_hdr, sd-quality); Best Regards. Nice to see microdia project here :) On Sat, Jul 18, 2009

Re: [PATCH 0/2] gspca sn9c20x subdriver rev2

2009-07-18 Thread Brian Johnson
shouldn't there be a check when allocating jpg_hdr? or i am missing something? sd-jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); jpeg_define(sd-jpeg_hdr, height, width, 0x21); jpeg_set_qual(sd-jpeg_hdr, sd-quality); Yes probably there should be a check there. I'll one more minor

[PATCH 0/2] gspca sn9c20x subdriver rev2

2009-07-17 Thread Brian Johnson
Mauro, Here is the updated version of the gspca sn9c20x subdriver. I've removed the custom debugging support and replaced it with support for the v4l2 debugging ioctls. The first patch in this set adds support to the gspca core for those ioctls. Also included are the fixes Hans sent in his last