Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-05-05 Thread Antonio Ospite
On Mon, 30 Apr 2012 15:51:01 +0200 Antonio Ospite wrote: > On Mon, 23 Apr 2012 14:16:25 -0600 > Jonathan Corbet wrote: > > > On Mon, 23 Apr 2012 15:21:04 +0200 > > Antonio Ospite wrote: > > > > > Jonathan, maybe fixp_sin() and fixp_cos() can be used in > > > drivers/media/video/ov7670.c too w

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-30 Thread Antonio Ospite
On Mon, 23 Apr 2012 14:16:25 -0600 Jonathan Corbet wrote: > On Mon, 23 Apr 2012 15:21:04 +0200 > Antonio Ospite wrote: > > > Jonathan, maybe fixp_sin() and fixp_cos() can be used in > > drivers/media/video/ov7670.c too where currently ov7670_sine() and > > ov7670_cosine() are defined, but I did

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Jonathan Corbet
On Mon, 23 Apr 2012 15:21:04 +0200 Antonio Ospite wrote: > Jonathan, maybe fixp_sin() and fixp_cos() can be used in > drivers/media/video/ov7670.c too where currently ov7670_sine() and > ov7670_cosine() are defined, but I didn't want to send a patch I could > not test. Seems like a good idea. N

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Dmitry Torokhov
On Mon, Apr 23, 2012 at 03:21:04PM +0200, Antonio Ospite wrote: > Hi, > > here are a couple more of controls for the gspca ov534 subdriver. > > In order to control the HUE value the sensor expects sin(HUE) and > cos(HUE) to be set so I decided to reuse the fixed point implementation > of sine and

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Antonio Ospite
If you "reply to all" please fix Johann Deneux's address, I mis-wrote it, sorry. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? p

[PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Antonio Ospite
Hi, here are a couple more of controls for the gspca ov534 subdriver. In order to control the HUE value the sensor expects sin(HUE) and cos(HUE) to be set so I decided to reuse the fixed point implementation of sine and cosine from drivers/input/fixp-arith.h, see patches 2 and 3. Dmitry, can the