Re: [PATCH 00/50] USB: cleanup spin_lock in URB-complete()

2013-07-14 Thread Andy Walls
On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote: Hi, As we are going to run URB-complete() in tasklet context[1][2], Hi, Please pardon my naivete, but why was it decided to use tasklets to defer work, as opposed to some other deferred work mechanism? It seems to me that getting rid of

Re: [PATCH 00/50] USB: cleanup spin_lock in URB-complete()

2013-07-14 Thread Ming Lei
On Sun, Jul 14, 2013 at 9:17 PM, Andy Walls awa...@md.metrocast.net wrote: On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote: Hi, As we are going to run URB-complete() in tasklet context[1][2], Hi, Please pardon my naivete, but why was it decided to use tasklets to defer work, as opposed

[PATCH 00/50] USB: cleanup spin_lock in URB-complete()

2013-07-11 Thread Ming Lei
Hi, As we are going to run URB-complete() in tasklet context[1][2], and hard interrupt may be enabled when running URB completion handler[3], so we might need to disable interrupt when acquiring one lock in the completion handler for the below reasons: - URB-complete() holds a subsystem wide