Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-25 Thread Arnd Bergmann
On Thursday 25 November 2010, Jimmy RUBIN wrote: > > All these header files, > Configuration, pixel processing, formatter, dsi link registers are auto > generated from an xml file. This actually may or may not be a legal problem, because it means that the distributed source code is not the prefe

RE: [PATCH 02/10] MCDE: Add configuration registers

2010-11-25 Thread Jimmy RUBIN
Hi, > > > > This patch adds the configuration registers found in MCDE. > > > + > > +#define MCDE_VAL2REG(__reg, __fld, __val) \ > > + (((__val) << __reg##_##__fld##_SHIFT) & > __reg##_##__fld##_MASK) > > +#define MCDE_REG2VAL(__reg, __fld, __val) \ > > + (((__val) & __reg##_##__fld##_MASK) >>

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-15 Thread Geert Uytterhoeven
On Mon, Nov 15, 2010 at 15:59, Russell King - ARM Linux wrote: > On Mon, Nov 15, 2010 at 03:25:54PM +0100, Arnd Bergmann wrote: >> On Friday 12 November 2010, Russell King - ARM Linux wrote: >> > It is a bad idea to describe device registers using C structures, and >> > especially enums. >> > >> >

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-15 Thread Russell King - ARM Linux
On Mon, Nov 15, 2010 at 03:25:54PM +0100, Arnd Bergmann wrote: > On Friday 12 November 2010, Russell King - ARM Linux wrote: > > It is a bad idea to describe device registers using C structures, and > > especially enums. > > > > The only thing C guarantees about structure layout is that the elemen

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-15 Thread Arnd Bergmann
On Friday 12 November 2010, Russell King - ARM Linux wrote: > On Fri, Nov 12, 2010 at 04:14:51PM +0100, Arnd Bergmann wrote: > > Some people prefer to express all this in C instead of macros: > > > > struct mcde_registers { > > enum { > > mcde_cr_dsicmd2_en = 0x0001, > >

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-12 Thread Russell King - ARM Linux
On Fri, Nov 12, 2010 at 04:14:51PM +0100, Arnd Bergmann wrote: > Some people prefer to express all this in C instead of macros: > > struct mcde_registers { > enum { > mcde_cr_dsicmd2_en = 0x0001, > mcde_cr_dsicmd1_en = 0x0002, > ... > }

Re: [PATCH 02/10] MCDE: Add configuration registers

2010-11-12 Thread Arnd Bergmann
On Wednesday 10 November 2010, Jimmy Rubin wrote: > This patch adds support for MCDE, Memory-to-display controller > found in the ST-Ericsson ux500 products. > > This patch adds the configuration registers found in MCDE. > + > +#define MCDE_VAL2REG(__reg, __fld, __val) \ > + (((__val) << __re