Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-02-03 Thread Pawel Osciak
Hi Tomasz, I like the direction in which you are going with the userspace handling. This is almost exactly as I envisioned it. I have one comment though: On Thu, Jan 26, 2012 at 01:48, Tomasz Stanislawski t.stanisl...@samsung.com wrote: [snip]        /* setup polling */        struct pollfd

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-02-03 Thread Pawel Osciak
Hi Tomasz, On Mon, Jan 23, 2012 at 05:51, Tomasz Stanislawski t.stanisl...@samsung.com wrote: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-30 Thread Laurent Pinchart
Hi Subash, On Friday 27 January 2012 14:40:34 Subash Patel wrote: On 01/24/2012 05:36 PM, Tomasz Stanislawski wrote: On 01/24/2012 12:07 PM, Subash Patel wrote: Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing ones in v4l2/vb2?

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-27 Thread Subash Patel
Hello Tomasz, Sorry for a late reply. Please find my answers inline. On 01/24/2012 05:36 PM, Tomasz Stanislawski wrote: Hi, On 01/24/2012 12:07 PM, Subash Patel wrote: Hello Thomasz, Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-26 Thread Tomasz Stanislawski
Hi Everyone, I would like to present a simple test application used for testing DMABUF support in V4L2. It is used to show how support for DMABUF may look like in V4L2. The test application creates a simple pipeline between two V4L2 devices. One of them is a capture device. The second one

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-24 Thread Laurent Pinchart
Hi Mauro, On Monday 23 January 2012 17:42:45 Mauro Carvalho Chehab wrote: Em 23-01-2012 13:56, Tomasz Stanislawski escreveu: On 01/23/2012 04:04 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 12:42, Tomasz Stanislawski escreveu: On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-24 Thread Subash Patel
Hello Thomasz, Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing ones in v4l2/vb2? When the memory type set is V4L2_MEMORY_DMABUF, call to VIDIOC_REQBUFS /VIDIOC_QUERYBUF from driver can take/return the fd. We will need to add

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-24 Thread Tomasz Stanislawski
Hi, On 01/24/2012 12:07 PM, Subash Patel wrote: Hello Thomasz, Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing ones in v4l2/vb2? When the memory type set is V4L2_MEMORY_DMABUF, call to VIDIOC_REQBUFS /VIDIOC_QUERYBUF from driver can

[PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Mauro Carvalho Chehab
Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. This requires more discussions.

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Laurent Pinchart
Hi Mauro, On Monday 23 January 2012 15:32:40 Mauro Carvalho Chehab wrote: Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Tomasz Stanislawski
Hi Mauro. On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Mauro Carvalho Chehab
Em 23-01-2012 12:42, Tomasz Stanislawski escreveu: Hi Mauro. On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added.

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Tomasz Stanislawski
Hi Mauro, On 01/23/2012 04:04 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 12:42, Tomasz Stanislawski escreveu: Hi Mauro. On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch adds extension to V4L2 api. It allow to export a mmap

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Mauro Carvalho Chehab
Em 23-01-2012 13:56, Tomasz Stanislawski escreveu: Hi Mauro, On 01/23/2012 04:04 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 12:42, Tomasz Stanislawski escreveu: Hi Mauro. On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 11:51, Tomasz Stanislawski escreveu: This patch

V4L2 Overlay mode replacement by dma-buf - was: Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Mauro Carvalho Chehab
Em 23-01-2012 14:42, Mauro Carvalho Chehab escreveu: Em 23-01-2012 13:56, Tomasz Stanislawski escreveu: Hi Mauro, On 01/23/2012 04:04 PM, Mauro Carvalho Chehab wrote: Em 23-01-2012 12:42, Tomasz Stanislawski escreveu: Hi Mauro. On 01/23/2012 03:32 PM, Mauro Carvalho Chehab wrote: Em

Re: V4L2 Overlay mode replacement by dma-buf - was: Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-23 Thread Clark, Rob
On Mon, Jan 23, 2012 at 10:57 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: 2) The userspace API changes to properly support for dma buffers. If you're not ready to discuss (2), that's ok, but I'd like to follow the discussions for it with care, not only for reviewing the actual