Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-18 Thread Tushar Behera
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: On Fri, 16 Nov 2012, Tushar Behera wrote: Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. Wouldn't just changing irq type to int also work? I think that would be a more

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-17 Thread Guennadi Liakhovetski
On Fri, 16 Nov 2012, Tushar Behera wrote: Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. Wouldn't just changing irq type to int also work? I think that would be a more straight-forward solution. If however there are strong arguments

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

2012-11-15 Thread Tushar Behera
Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/platform/soc_camera/atmel-isi.c |2