Re: [PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-04-19 Thread Rui Miguel Silva
Hi Dan, On Thu 19 Apr 2018 at 12:45, Dan Carpenter wrote: +static int mipi_csis_clk_get(struct csi_state *state) +{ + struct device *dev = &state->pdev->dev; + int ret = true; Better to leave ret unitialized. ack. + + state->mipi_clk = devm_clk_get(dev, "mipi"); +

Re: [PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-04-19 Thread Dan Carpenter
> +static int mipi_csis_clk_get(struct csi_state *state) > +{ > + struct device *dev = &state->pdev->dev; > + int ret = true; Better to leave ret unitialized. > + > + state->mipi_clk = devm_clk_get(dev, "mipi"); > + if (IS_ERR(state->mipi_clk)) { > + dev_err(dev, "Cou

[PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-04-19 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed, 1155 insertions(+) create mode