Re: [PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-30 Thread Philipp Zabel
Am Montag, den 30.09.2013, 13:50 +0200 schrieb Hans Verkuil: > On 09/19/2013 11:13 AM, Philipp Zabel wrote: > > Moving the ioctl handler callbacks into the coda namespace helps > > tremendously to make sense of backtraces. > > I like the idea, but I would just use the coda_ prefix, not coda_vidioc

Re: [PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:13 AM, Philipp Zabel wrote: > Moving the ioctl handler callbacks into the coda namespace helps > tremendously to make sense of backtraces. I like the idea, but I would just use the coda_ prefix, not coda_vidioc_. In general the prefix is either vidioc_ or the name of the driver,

[PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-19 Thread Philipp Zabel
Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda.c | 123 +- 1 file changed, 63 insertions(+), 60 deletions(-) diff --git a/drivers/medi