RE: [PATCH 08/10] MCDE: Add frame buffer device

2010-11-25 Thread Jimmy RUBIN
Hi, > > On Wednesday 10 November 2010, Jimmy Rubin wrote: > > + > > +static struct platform_device mcde_fb_device = { > > + .name = "mcde_fb", > > + .id = -1, > > +}; > > Do not introduce new static devices. We are trying to remove them and > they will stop working. Why do you even need a de

Re: [PATCH 08/10] MCDE: Add frame buffer device

2010-11-12 Thread Arnd Bergmann
On Wednesday 10 November 2010, Jimmy Rubin wrote: > + > +static struct platform_device mcde_fb_device = { > + .name = "mcde_fb", > + .id = -1, > +}; Do not introduce new static devices. We are trying to remove them and they will stop working. Why do you even need a device here if there is

[PATCH 08/10] MCDE: Add frame buffer device

2010-11-10 Thread Jimmy Rubin
This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. This patch adds a frame buffer device driver that uses the DSS. Signed-off-by: Jimmy Rubin Acked-by: Linus Walleij --- drivers/video/mcde/mcde_fb.c | 697 ++