On Wed, Dec 05, 2018 at 04:15:17PM +0200, Sakari Ailus wrote:
> The device won't be powered off on systems that have no sensors connected
> unless it has a driver bound to it. Allow that to happen even if there are
> no sensors connected to cio2.
Thanks for sending this. It helps to put the pci device to suspend which
otherwise remains active after the probe for cio2 fails. I have verified it
on HP Elitebook that has BIOS/DSDT more suitable for Windows.
>
> Signed-off-by: Sakari Ailus
Reviewed-and-tested-by: Rajneesh Bhardwaj
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 447baaebca448..e281e55cdca4a 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1810,7 +1810,8 @@ static int cio2_pci_probe(struct pci_dev *pci_dev,
>
> /* Register notifier for subdevices we care */
> r = cio2_notifier_init(cio2);
> - if (r)
> + /* Proceed without sensors connected to allow the device to suspend. */
> + if (r && r != -ENODEV)
> goto fail_cio2_queue_exit;
>
> r = devm_request_irq(_dev->dev, pci_dev->irq, cio2_irq,
> --
> 2.11.0
>
--
Best Regards,
Rajneesh
