Re: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Vladimir Pantelic
hvaib...@ti.com wrote: From: Vaibhav Hiremathhvaib...@ti.com Features Supported - 1. Provides V4L2 user interface for the video pipelines of DSS 2. Basic streaming working on LCD, DVI and TV. 3. Works on latest DSS2 library from Tomi 4. Support for various pixel

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Hiremath, Vaibhav
-Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Tuesday, April 06, 2010 11:59 PM To: Hiremath, Vaibhav Cc: linux-media@vger.kernel.org; Karicheri, Muralidharan; mche...@redhat.com; linux-o...@vger.kernel.org; t...@atomide.com Subject: Re: [PATCH 1/2] OMAP2/3

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Hiremath, Vaibhav
-Original Message- From: Karicheri, Muralidharan Sent: Tuesday, April 06, 2010 11:56 PM To: Hiremath, Vaibhav; Muralidharan Karicheri Cc: linux-media@vger.kernel.org; mche...@redhat.com; linux- o...@vger.kernel.org; t...@atomide.com Subject: RE: [PATCH 1/2] OMAP2/3 V4L2: Add

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-07 Thread Karicheri, Muralidharan
Vaibhav, [Murali] Shouldn't we remove omap_vout_uservirt_to_phys() and use videobuf_iolock() instead as we have done in vpfe_capture.c? As mentioned before, in my opinion we can address this in sub-sequent patch series, and should not block this patch in getting to main-line. +/* + * Convert

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-06 Thread Hiremath, Vaibhav
-Original Message- From: Muralidharan Karicheri [mailto:mkarich...@gmail.com] Sent: Saturday, April 03, 2010 1:33 AM To: Hiremath, Vaibhav Cc: linux-media@vger.kernel.org; Karicheri, Muralidharan; mche...@redhat.com; linux-o...@vger.kernel.org; t...@atomide.com Subject: Re: [PATCH

RE: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-06 Thread Karicheri, Muralidharan
Vaibhav, [Hiremath, Vaibhav] Thanks Murali, I really appreciate your comments here. Please find response below - You had responded only to some comments. Can I assume that you are taking care of the other comments as well? I have also asked Hans to provide his comments since this is a new