Re: [PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

[Sakari Ailus]

Hi Jacopo,

On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for Micron MT9T111/MT9T112 image
> sensors.
> 
> Signed-off-by: Jacopo Mondi 
> ---
>  Documentation/devicetree/bindings/mt9t112.txt | 41 
> +++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mt9t112.txt
> 
> diff --git a/Documentation/devicetree/bindings/mt9t112.txt 
> b/Documentation/devicetree/bindings/mt9t112.txt
> new file mode 100644
> index 000..cbad475
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mt9t112.txt
> @@ -0,0 +1,41 @@
> +Micron 3.1Mp CMOS Digital Image Sensor
> +--
> +
> +The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
> +digital image sensors which support up to QXGA (2048x1536) image resolution 
> in
> +4/3 format.
> +
> +The sensors can be programmed through a two-wire serial interface and can
> +work both in parallel data output mode as well as in MIPI CSI-2 mode.
> +
> +Required Properties:
> +- compatible: shall be one of the following values
> + "micron,mt9t111" for MT9T111 sensors
> + "micron,mt9t112" for MT9T112 sensors
> +
> +Optional properties:
> +- powerdown-gpios: reference to powerdown input GPIO signal. Pin name 
> "STANDBY".
> +  Active level is high.
> +
> +The device node shall contain one 'port' sub-node with one 'endpoint' child
> +node, modeled accordingly to bindings described in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> +
> + mt9t112@3d {
> + compatible = "micron,mt9t112";
> + reg = <0x3d>;
> +
> + powerdown-gpios = < 2 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + mt9t112_out: endpoint {
> + pclk-sample = <1>;

Could you document pclk-sample as an endpoint property? I'd suggest making
it optional with a default configuration.

> + remote-endpoint = <_in>;
> + };
> + };
> + };
> +
> +

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi

Re: [PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

[Rob Herring]

On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote:
> Add device tree bindings documentation for Micron MT9T111/MT9T112 image
> sensors.
> 
> Signed-off-by: Jacopo Mondi 
> ---
>  Documentation/devicetree/bindings/mt9t112.txt | 41 
> +++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mt9t112.txt
> 
> diff --git a/Documentation/devicetree/bindings/mt9t112.txt 
> b/Documentation/devicetree/bindings/mt9t112.txt
> new file mode 100644
> index 000..cbad475
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mt9t112.txt
> @@ -0,0 +1,41 @@
> +Micron 3.1Mp CMOS Digital Image Sensor
> +--
> +
> +The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
> +digital image sensors which support up to QXGA (2048x1536) image resolution 
> in
> +4/3 format.
> +
> +The sensors can be programmed through a two-wire serial interface and can
> +work both in parallel data output mode as well as in MIPI CSI-2 mode.
> +
> +Required Properties:
> +- compatible: shall be one of the following values
> + "micron,mt9t111" for MT9T111 sensors
> + "micron,mt9t112" for MT9T112 sensors
> +
> +Optional properties:
> +- powerdown-gpios: reference to powerdown input GPIO signal. Pin name 
> "STANDBY".
> +  Active level is high.
> +
> +The device node shall contain one 'port' sub-node with one 'endpoint' child
> +node, modeled accordingly to bindings described in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> +
> + mt9t112@3d {

camera-sensor@3d

Otherwise,

Reviewed-by: Rob Herring 

> + compatible = "micron,mt9t112";
> + reg = <0x3d>;
> +
> + powerdown-gpios = < 2 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + mt9t112_out: endpoint {
> + pclk-sample = <1>;
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> +
> +
> -- 
> 2.7.4
> 

[PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

[Jacopo Mondi]

Add device tree bindings documentation for Micron MT9T111/MT9T112 image
sensors.

Signed-off-by: Jacopo Mondi 
---
 Documentation/devicetree/bindings/mt9t112.txt | 41 +++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mt9t112.txt

diff --git a/Documentation/devicetree/bindings/mt9t112.txt 
b/Documentation/devicetree/bindings/mt9t112.txt
new file mode 100644
index 000..cbad475
--- /dev/null
+++ b/Documentation/devicetree/bindings/mt9t112.txt
@@ -0,0 +1,41 @@
+Micron 3.1Mp CMOS Digital Image Sensor
+--
+
+The Micron MT9T111 and MT9T112 are 1/4 inch 3.1Mp System-On-A-Chip (SOC) CMOS
+digital image sensors which support up to QXGA (2048x1536) image resolution in
+4/3 format.
+
+The sensors can be programmed through a two-wire serial interface and can
+work both in parallel data output mode as well as in MIPI CSI-2 mode.
+
+Required Properties:
+- compatible: shall be one of the following values
+   "micron,mt9t111" for MT9T111 sensors
+   "micron,mt9t112" for MT9T112 sensors
+
+Optional properties:
+- powerdown-gpios: reference to powerdown input GPIO signal. Pin name 
"STANDBY".
+  Active level is high.
+
+The device node shall contain one 'port' sub-node with one 'endpoint' child
+node, modeled accordingly to bindings described in:
+Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Example:
+
+
+   mt9t112@3d {
+   compatible = "micron,mt9t112";
+   reg = <0x3d>;
+
+   powerdown-gpios = < 2 GPIO_ACTIVE_HIGH>;
+
+   port {
+   mt9t112_out: endpoint {
+   pclk-sample = <1>;
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+
+
-- 
2.7.4