Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

ok, I'll check this patch on tw5864 hardware bit later and report results here On Thu, May 18, 2017 at 10:48 PM, Andrey Utkin wrote: > On Thu, May 18, 2017 at 11:06:43AM -0300, Mauro Carvalho Chehab wrote: >> As such macro will check if the expression is true, it may

Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

On Thu, 18 May 2017 11:06:43 -0300 Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/tuners/fc0011.c b/drivers/media/tuners/fc0011.c > index 192b1c7740df..145407dee3db 100644 > --- a/drivers/media/tuners/fc0011.c > +++ b/drivers/media/tuners/fc0011.c > @@ -342,6

Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

On Thu, May 18, 2017 at 11:06:43AM -0300, Mauro Carvalho Chehab wrote: > As such macro will check if the expression is true, it may fall through, as > warned: > On both cases, it means an error, so, let's return an error > code, to make gcc happy. > > Signed-off-by: Mauro Carvalho Chehab

[PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

As such macro will check if the expression is true, it may fall through, as warned: In file included from ./include/uapi/linux/stddef.h:1:0, from ./include/linux/stddef.h:4, from ./include/uapi/linux/posix_types.h:4, from