Glad this is spurring a lot of conversation, and I’m happy to see this many
contributors too. I think we have all solved many of these problems (and the
many others) offline, and now it’s the hard part to try to glue them all
together. I decided to jump back in the mix with these patches
Hi Hugues,
On Monday, 15 October 2018 18:13:12 EEST Hugues FRUCHET wrote:
> Hi Laurent, Jacopo, Sam,
>
> I'm also OK to change to a simpler alternative;
> - drop the "restore" step
> - send the whole init register sequence + mode changes + format changes
> at streamon
>
> is this what you have
Hi Jacopo,
On 10/15/2018 05:24 PM, jacopo mondi wrote:
> Hi Hugues,
>
> On Mon, Oct 15, 2018 at 03:13:12PM +, Hugues FRUCHET wrote:
>> Hi Laurent, Jacopo, Sam,
>>
>> I'm also OK to change to a simpler alternative;
>> - drop the "restore" step
>
> Do you mean the restore step at the end of
Hi Hugues,
On Mon, Oct 15, 2018 at 03:13:12PM +, Hugues FRUCHET wrote:
> Hi Laurent, Jacopo, Sam,
>
> I'm also OK to change to a simpler alternative;
> - drop the "restore" step
Do you mean the restore step at the end of 'ov5640_restore_mode()' ?
I agree, I've been carrying this one [1] in
Hi Laurent, Jacopo, Sam,
I'm also OK to change to a simpler alternative;
- drop the "restore" step
- send the whole init register sequence + mode changes + format changes
at streamon
is this what you have in mind Laurent ?
On 10/10/2018 02:41 PM, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On
Hi Jacopo,
On Wednesday, 10 October 2018 13:58:04 EEST jacopo mondi wrote:
> Hi Sam,
>thanks for the patch, I see the same issue you reported, but I
> think this patch can be improved.
>
> (expanding the Cc list to all people involved in recent ov5640
> developemts, not just for this patch,
Hi Sam,
thanks for the patch, I see the same issue you reported, but I
think this patch can be improved.
(expanding the Cc list to all people involved in recent ov5640
developemts, not just for this patch, but for the whole series to look
at. Copying names from another series cover letter,
set_fmt was not properly triggering a mode change when
a new mode was set that happened to have the same format
as the previous mode (for example, when only changing the
frame dimensions). Fix this.
Signed-off-by: Sam Bobrowicz
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4
