Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-07-02 Thread Randy Li
On 06/27/2017 11:49 PM, Nicolas Dufresne wrote: Le mardi 27 juin 2017 à 23:11 +0800, Jacob Chen a écrit : Hi Nicolas. 2017-06-26 23:49 GMT+08:00 Nicolas Dufresne : Le lundi 26 juin 2017 à 22:51 +0800, Jacob Chen a écrit : Rockchip RGA is a separate 2D raster graphic

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Jacob Chen
Hi, 2017-06-27 16:39 GMT+08:00 Tomasz Figa : > Hi Jacob, > > Please see my comments inline. > > On Mon, Jun 26, 2017 at 11:51 PM, Jacob Chen wrote: >> Rockchip RGA is a separate 2D raster graphic acceleration unit. It >> accelerates 2D graphics

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Nicolas Dufresne
Le mardi 27 juin 2017 à 23:11 +0800, Jacob Chen a écrit : > Hi Nicolas. > > 2017-06-26 23:49 GMT+08:00 Nicolas Dufresne : > > > > Le lundi 26 juin 2017 à 22:51 +0800, Jacob Chen a écrit : > > > Rockchip RGA is a separate 2D raster graphic acceleration unit. > > > It > > >

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Jacob Chen
Hi Tomasz, Yeah, the comments are wrong, i will correct it >> +*/ >> + pages = (unsigned int *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, 3); > > This is rather unfortunate and you should expect failures here on > actively used systems with uptime longer than few hours. Changing this

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Jacob Chen
Hi Nicolas. 2017-06-26 23:49 GMT+08:00 Nicolas Dufresne : > > Le lundi 26 juin 2017 à 22:51 +0800, Jacob Chen a écrit : > > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > > accelerates 2D graphics operations, such as point/line drawing, image > >

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Tomasz Figa
Hi Jacob, Please see my comments inline. On Mon, Jun 26, 2017 at 11:51 PM, Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-26 Thread Nicolas Dufresne
Le lundi 26 juin 2017 à 22:51 +0800, Jacob Chen a écrit : > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness. > > The drvier is mostly

[PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-26 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness. The drvier is mostly based on s5p-g2d v4l2 m2m driver. And supports various operations from