Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2013-01-07 Thread Hans Verkuil
On Thu December 27 2012 12:59:15 Hans Verkuil wrote: On Wed December 26 2012 12:33:58 Laurent Pinchart wrote: Hi Hans, On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:15:25 Hans Verkuil

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-27 Thread Hans Verkuil
On Wed December 26 2012 12:33:58 Laurent Pinchart wrote: Hi Hans, On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:15:25 Hans Verkuil wrote: On Mon December 24 2012 13:27:08 Laurent

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-27 Thread Laurent Pinchart
Hi Hans, On Thursday 27 December 2012 12:59:15 Hans Verkuil wrote: On Wed December 26 2012 12:33:58 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:15:25 Hans Verkuil

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-26 Thread Laurent Pinchart
Hi Hans, On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:15:25 Hans Verkuil wrote: On Mon December 24 2012 13:27:08 Laurent Pinchart wrote: On Thursday 27 September 2012 17:16:15 Laurent

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-26 Thread Mauro Carvalho Chehab
Em Wed, 26 Dec 2012 12:33:58 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: Hi Hans, On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012 12:15:25 Hans Verkuil wrote: On Mon

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-26 Thread Laurent Pinchart
Hi Mauro, On Wednesday 26 December 2012 12:00:35 Mauro Carvalho Chehab wrote: Em Wed, 26 Dec 2012 12:33:58 +0100 Laurent Pinchart escreveu: On Tuesday 25 December 2012 12:50:51 Hans Verkuil wrote: On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: On Tuesday 25 December 2012

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-25 Thread Hans Verkuil
On Mon December 24 2012 13:27:08 Laurent Pinchart wrote: Hi Hans, On Thursday 27 September 2012 17:16:15 Laurent Pinchart wrote: When one of the requested controls doesn't exist the error_idx field must reflect that situation. For G_EXT_CTRLS and S_EXT_CTRLS, error_idx must be set to the

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-25 Thread Laurent Pinchart
Hi Hans, On Tuesday 25 December 2012 12:15:25 Hans Verkuil wrote: On Mon December 24 2012 13:27:08 Laurent Pinchart wrote: On Thursday 27 September 2012 17:16:15 Laurent Pinchart wrote: When one of the requested controls doesn't exist the error_idx field must reflect that situation. For

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-25 Thread Hans Verkuil
On Tue December 25 2012 12:23:00 Laurent Pinchart wrote: Hi Hans, On Tuesday 25 December 2012 12:15:25 Hans Verkuil wrote: On Mon December 24 2012 13:27:08 Laurent Pinchart wrote: On Thursday 27 September 2012 17:16:15 Laurent Pinchart wrote: When one of the requested controls doesn't

Re: [PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-12-24 Thread Laurent Pinchart
Hi Hans, On Thursday 27 September 2012 17:16:15 Laurent Pinchart wrote: When one of the requested controls doesn't exist the error_idx field must reflect that situation. For G_EXT_CTRLS and S_EXT_CTRLS, error_idx must be set to the control count. For TRY_EXT_CTRLS, it must be set to the index

[PATCH 1/6] uvcvideo: Set error_idx properly for extended controls API failures

2012-09-27 Thread Laurent Pinchart
When one of the requested controls doesn't exist the error_idx field must reflect that situation. For G_EXT_CTRLS and S_EXT_CTRLS, error_idx must be set to the control count. For TRY_EXT_CTRLS, it must be set to the index of the unexisting control. This issue was found by the v4l2-compliance