Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-30 Thread Hans Verkuil
Hi Sakari, On 01/29/2018 06:06 PM, Sakari Ailus wrote: > Hi Hans, > > Thanks for your efforts on this patch and the patchset. Please see my > comments below. > > On Fri, Jan 26, 2018 at 01:43:27PM +0100, Hans Verkuil wrote: >> From: Daniel Mentz >> >> The 32-bit compat

Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-29 Thread Sakari Ailus
Hi Hans, On Mon, Jan 29, 2018 at 06:41:20PM +0100, Hans Verkuil wrote: > On 01/29/2018 06:06 PM, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for your efforts on this patch and the patchset. Please see my > > comments below. > > > > On Fri, Jan 26, 2018 at 01:43:27PM +0100, Hans Verkuil

Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-29 Thread Hans Verkuil
On 01/29/2018 06:06 PM, Sakari Ailus wrote: > Hi Hans, > > Thanks for your efforts on this patch and the patchset. Please see my > comments below. > > On Fri, Jan 26, 2018 at 01:43:27PM +0100, Hans Verkuil wrote: >> From: Daniel Mentz >> >> The 32-bit compat v4l2 ioctl

Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-29 Thread Sakari Ailus
Hi Hans, Thanks for your efforts on this patch and the patchset. Please see my comments below. On Fri, Jan 26, 2018 at 01:43:27PM +0100, Hans Verkuil wrote: > From: Daniel Mentz > > The 32-bit compat v4l2 ioctl is implemented based on its 64-bit s/v4l2 ioctl/V4L2

Re: [PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-29 Thread Mauro Carvalho Chehab
Em Fri, 26 Jan 2018 13:43:27 +0100 Hans Verkuil escreveu: > From: Daniel Mentz > > The 32-bit compat v4l2 ioctl is implemented based on its 64-bit > equivalent. It converts 32-bit data structures into its 64-bit > equivalents and needs to provide the

[PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-26 Thread Hans Verkuil
From: Daniel Mentz The 32-bit compat v4l2 ioctl is implemented based on its 64-bit equivalent. It converts 32-bit data structures into its 64-bit equivalents and needs to provide the data to the 64-bit ioctl in user space memory which is commonly allocated using