Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

On 11/16/2018 09:45 AM, Tomasz Figa wrote: > On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: >> >> On 11/16/2018 09:34 AM, Tomasz Figa wrote: >>> Hi Hans, >>> >>> On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: Calling the stop_streaming op can release the core serialization lo

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: > > On 11/16/2018 09:34 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling the stop_streaming op can release the core serialization lock > >> pointed to by vb2_queue->lock if it has

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

On 11/16/2018 09:34 AM, Tomasz Figa wrote: > Hi Hans, > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: >> >> Calling the stop_streaming op can release the core serialization lock >> pointed to by vb2_queue->lock if it has to wait for buffers to finish. >> An example of that behavior is th

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling the stop_streaming op can release the core serialization lock > pointed to by vb2_queue->lock if it has to wait for buffers to finish. > An example of that behavior is the vivid driver. Why would vb2_queue->lock have to be

[PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

Calling the stop_streaming op can release the core serialization lock pointed to by vb2_queue->lock if it has to wait for buffers to finish. An example of that behavior is the vivid driver. However, if userspace dup()ped the video device filehandle, then it is possible to stop streaming on one fil