Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Ezequiel Garcia
Hi Nicolas, On Fri, 2018-10-19 at 07:41 -0400, Nicolas Dufresne wrote: > Le vendredi 19 octobre 2018 à 07:35 -0400, Nicolas Dufresne a écrit : > > Le vendredi 19 octobre 2018 à 09:28 +0200, Hans Verkuil a écrit : > > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > > > Set up a

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Ezequiel Garcia
On Fri, 2018-10-19 at 09:28 +0200, Hans Verkuil wrote: > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > Set up a statically-allocated, dummy buffer to > > be used as flush buffer, which signals > > a encoding (or decoding) stop. > > > > When the flush buffer is queued to the OUTPUT queue, > >

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Nicolas Dufresne
Le vendredi 19 octobre 2018 à 07:35 -0400, Nicolas Dufresne a écrit : > Le vendredi 19 octobre 2018 à 09:28 +0200, Hans Verkuil a écrit : > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > > Set up a statically-allocated, dummy buffer to > > > be used as flush buffer, which signals > > > a

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Hans Verkuil
On 10/19/18 13:35, Nicolas Dufresne wrote: > Le vendredi 19 octobre 2018 à 09:28 +0200, Hans Verkuil a écrit : >> On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: >>> Set up a statically-allocated, dummy buffer to >>> be used as flush buffer, which signals >>> a encoding (or decoding) stop. >>> >>>

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Nicolas Dufresne
Le vendredi 19 octobre 2018 à 09:28 +0200, Hans Verkuil a écrit : > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > Set up a statically-allocated, dummy buffer to > > be used as flush buffer, which signals > > a encoding (or decoding) stop. > > > > When the flush buffer is queued to the OUTPUT

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Hans Verkuil
On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > Set up a statically-allocated, dummy buffer to > be used as flush buffer, which signals > a encoding (or decoding) stop. > > When the flush buffer is queued to the OUTPUT queue, > the driver will send an V4L2_EVENT_EOS event, and > mark the CAPTURE

[PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-18 Thread Ezequiel Garcia
Set up a statically-allocated, dummy buffer to be used as flush buffer, which signals a encoding (or decoding) stop. When the flush buffer is queued to the OUTPUT queue, the driver will send an V4L2_EVENT_EOS event, and mark the CAPTURE buffer with V4L2_BUF_FLAG_LAST. With this change, it's