Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
2001 From: Marek Vasut marek.va...@gmail.com Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut marek.va...@gmail.com Ok, I see, you rebased your patches on my soc-camera patch-stack, this is good

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Guennadi Liakhovetski
On Mon, 14 Sep 2009, Marek Vasut wrote: [snip] +/* NOTE: The RGB555X format still has issues, so it's left out. */ +static const struct soc_camera_data_format ov9640_fmt_lists[] = { +{ + .name = VYUY, + .fourcc = V4L2_PIX_FMT_VYUY, + .depth = 16, +

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 16:45:50 Guennadi Liakhovetski napsal(a): Ok, you were faster than I:-) If you agree, I can just remove those two RGB formats myself, changing your comment to a TODO, We can #ifdef them so others dont have to re-add them by hand if they want to try fixing those. and

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Ne 13. září 2009 21:13:32 Guennadi Liakhovetski napsal(a): On Sun, 13 Sep 2009, Marek Vasut wrote: Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): Ok, a couple more simple questions / remarks, In principle, there's just one principle objection - if we agree, that

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Guennadi Liakhovetski
Ok, you were faster than I:-) If you agree, I can just remove those two RGB formats myself, changing your comment to a TODO, and modify the comment next to msleep(150) (if you could tell me what value didn't work, that would be appreciated) and push it out. Thanks Guennadi --- Guennadi

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-14 Thread Marek Vasut
Dne Po 14. září 2009 16:35:24 Marek Vasut napsal(a): Dne Ne 13. září 2009 21:13:32 Guennadi Liakhovetski napsal(a): On Sun, 13 Sep 2009, Marek Vasut wrote: Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): Ok, a couple more simple questions / remarks, In principle,

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-13 Thread Marek Vasut
2001 From: Marek Vasut marek.va...@gmail.com Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut marek.va...@gmail.com Ok, I see, you rebased your patches on my soc-camera patch-stack, this is good

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-13 Thread Guennadi Liakhovetski
On Sun, 13 Sep 2009, Marek Vasut wrote: Dne Pá 11. září 2009 23:51:44 Guennadi Liakhovetski napsal(a): Ok, a couple more simple questions / remarks, In principle, there's just one principle objection - if we agree, that the correct format is BGR565 and RGB565X, then we should change

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-11 Thread Guennadi Liakhovetski
2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut marek.va...@gmail.com Ok, I see, you rebased your patches on my soc-camera patch-stack, this is good, thanks. But you missed a couple of my comments - you still have a few

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-09-04 Thread Marek Vasut
Dne Po 24. srpna 2009 20:06:29 Guennadi Liakhovetski napsal(a): Hi Marek On Sat, 22 Aug 2009, Marek Vasut wrote: From 479aafc9a6540efec8a691a84aff166eb0218a72 Mon Sep 17 00:00:00 2001 From: Marek Vasut marek.va...@gmail.com Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add

Re: [PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-08-24 Thread Guennadi Liakhovetski
Hi Marek On Sat, 22 Aug 2009, Marek Vasut wrote: From 479aafc9a6540efec8a691a84aff166eb0218a72 Mon Sep 17 00:00:00 2001 From: Marek Vasut marek.va...@gmail.com Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut

[PATCH 2/3] Add driver for OmniVision OV9640 sensor

2009-08-22 Thread Marek Vasut
From 479aafc9a6540efec8a691a84aff166eb0218a72 Mon Sep 17 00:00:00 2001 From: Marek Vasut marek.va...@gmail.com Date: Sat, 22 Aug 2009 05:14:23 +0200 Subject: [PATCH 2/3] Add driver for OmniVision OV9640 sensor Signed-off-by: Marek Vasut marek.va...@gmail.com --- drivers/media/video/Kconfig