Re: [PATCH 2/3] media: coda: Add driver for Coda video codec.

2012-07-09 Thread Philipp Zabel
Am Montag, den 09.07.2012, 10:14 +0200 schrieb javier Martin: [...] > >> +enum coda_platform { > >> + CODA_INVALID = 0, > > > > I don't think CODA_INVALID is useful. > > It is, otherwise the following will fail since CODA_IMX27 is 0: > > if (of_id) > dev->devtype = of_id->

Re: [PATCH 2/3] media: coda: Add driver for Coda video codec.

2012-07-09 Thread javier Martin
On 9 July 2012 10:19, Philipp Zabel wrote: > Am Montag, den 09.07.2012, 10:07 +0200 schrieb javier Martin: > [...] >> >> +static int vidioc_s_parm(struct file *file, void *priv, struct >> >> v4l2_streamparm *a) >> >> +{ >> >> + struct coda_ctx *ctx = fh_to_ctx(priv); >> >> + >> >> + if (a

Re: [PATCH 2/3] media: coda: Add driver for Coda video codec.

2012-07-09 Thread Philipp Zabel
Am Montag, den 09.07.2012, 10:07 +0200 schrieb javier Martin: [...] > >> +static int vidioc_s_parm(struct file *file, void *priv, struct > >> v4l2_streamparm *a) > >> +{ > >> + struct coda_ctx *ctx = fh_to_ctx(priv); > >> + > >> + if (a->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) { > >> +

Re: [PATCH 2/3] media: coda: Add driver for Coda video codec.

2012-07-06 Thread Russell King - ARM Linux
On Fri, Jul 06, 2012 at 02:57:50PM +0200, Javier Martin wrote: > +config VIDEO_CODA > + tristate "Chips&Media Coda multi-standard codec IP" > + depends on VIDEO_DEV && VIDEO_V4L2 && SOC_IMX27 > + select VIDEOBUF2_DMA_CONTIG > + select V4L2_MEM2MEM_DEV > + default n Please, no m