RE: [PATCH 2/4] media: max2175: don't clear V4L2_SUBDEV_FL_IS_I2C

2017-10-20 Thread Ramesh Shanmugasundaram
Hi Mita-san, Thank you for fixing this. > Subject: [PATCH 2/4] media: max2175: don't clear V4L2_SUBDEV_FL_IS_I2C > > The v4l2_i2c_subdev_init() sets V4L2_SUBDEV_FL_IS_I2C flag in the > subdev->flags. But this driver overwrites subdev->flags immediately > su

[PATCH 2/4] media: max2175: don't clear V4L2_SUBDEV_FL_IS_I2C

2017-10-19 Thread Akinobu Mita
The v4l2_i2c_subdev_init() sets V4L2_SUBDEV_FL_IS_I2C flag in the subdev->flags. But this driver overwrites subdev->flags immediately after calling v4l2_i2c_subdev_init(). So V4L2_SUBDEV_FL_IS_I2C is not set after all. This stops breaking subdev->flags and preserves V4L2_SUBDEV_FL_IS_I2C. Side