Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Sascha Hauer
On Tue, Apr 14, 2009 at 10:57:32AM +0200, Guennadi Liakhovetski wrote: On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: Hi Sascha, something, that skipped both of us: ...and one more: On Thu, 12 Mar 2009, Sascha Hauer wrote: Some Phytec cameras have a I2C GPIO expander which

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Guennadi Liakhovetski
On Tue, 14 Apr 2009, Sascha Hauer wrote: On Tue, Apr 14, 2009 at 10:57:32AM +0200, Guennadi Liakhovetski wrote: On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: [snip] +static unsigned long pcm990_camera_query_bus_param(struct soc_camera_link *link) +{ + int ret; +

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Sascha Hauer
On Tue, Apr 14, 2009 at 11:53:54AM +0200, Guennadi Liakhovetski wrote: On Tue, 14 Apr 2009, Sascha Hauer wrote: On Tue, Apr 14, 2009 at 11:20:03AM +0200, Guennadi Liakhovetski wrote: If you don't object, I'll just add a .free_bus method to soc_camera_link, and switch pcm990 to only

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-14 Thread Guennadi Liakhovetski
On Thu, 9 Apr 2009, Guennadi Liakhovetski wrote: Hi Sascha, something, that skipped both of us: ...and one more: On Thu, 12 Mar 2009, Sascha Hauer wrote: Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-04-09 Thread Guennadi Liakhovetski
Hi Sascha, something, that skipped both of us: On Thu, 12 Mar 2009, Sascha Hauer wrote: Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously handled in the camera driver. Since handling of this switch varies on

[PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously handled in the camera driver. Since handling of this switch varies on several boards the cameras are used on, the board support seems a better place to handle the switch

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
baseboard: add camera bus width switch setting Some Phytec cameras have a I2C GPIO expander which allows it to switch between different sensor bus widths. This was previously handled in the camera driver. Since handling of this switch varies on several boards the cameras are used on, the board support

Re: [PATCH 2/5] pcm990 baseboard: add camera bus width switch setting

2009-03-12 Thread Sascha Hauer
On Thu, Mar 12, 2009 at 08:11:27PM +0100, Guennadi Liakhovetski wrote: ...one more thing. I noticed, that after patch 2 the cameras would stop work, because iclink-gpio would be set to 0. Which would break bisection. Ok, this is rather theoretical, still I modified the patches a bit.