Re: [PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-09 Thread Andreas Oberritter
On 05/09/2011 06:12 AM, Mauro Carvalho Chehab wrote: Em 09-05-2011 05:58, Mauro Carvalho Chehab escreveu: Em 09-05-2011 01:03, Andreas Oberritter escreveu: - Use const pointers and remove assignments. That's OK. - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM and

[PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Andreas Oberritter
- Use const pointers and remove assignments. - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM and dtv_property_cache_sync. Signed-off-by: Andreas Oberritter o...@linuxtv.org --- drivers/media/dvb/dvb-core/dvb_frontend.c | 13 +++-- 1 files changed, 3 insertions(+), 10

Re: [PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Mauro Carvalho Chehab
Em 09-05-2011 01:03, Andreas Oberritter escreveu: - Use const pointers and remove assignments. That's OK. - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM and dtv_property_cache_sync. The logic for those legacy params is too complex. It is easy that a latter patch to break

Re: [PATCH 2/8] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-05-08 Thread Mauro Carvalho Chehab
Em 09-05-2011 05:58, Mauro Carvalho Chehab escreveu: Em 09-05-2011 01:03, Andreas Oberritter escreveu: - Use const pointers and remove assignments. That's OK. - delivery_system already gets assigned by DTV_DELIVERY_SYSTEM and dtv_property_cache_sync. The logic for those legacy params