On 03/11/16 20:56, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 24 Oct 2016 22:44:02 +0200
Move the assignment for the data structure members "isoc_copy"
and "num_bufs" behind the source code for memory allocations
by this function.
I don't see the point,
Another explanation try
>> From: Markus Elfring
>> Date: Mon, 24 Oct 2016 22:44:02 +0200
>>
>> Move the assignment for the data structure members "isoc_copy"
>> and "num_bufs" behind the source code for memory allocations
>> by this function.
>
> I don't see the point,
Another explanation try …
> dropping this patch.
On 24/10/16 23:01, SF Markus Elfring wrote:
From: Markus Elfring
Date: Mon, 24 Oct 2016 22:44:02 +0200
Move the assignment for the data structure members "isoc_copy"
and "num_bufs" behind the source code for memory allocations
by this function.
I don't see the point, dropping this patch.
This patch introduces bugs. It's my policy to not explain the Markus's
bugs because otherwise he will just resend the patchset and I have asked
him many times to stop.
I will happily review bug fix patches but I really think he should stop
sending these cleanup patches.
regards,
dan carpenter
-
From: Markus Elfring
Date: Mon, 24 Oct 2016 22:44:02 +0200
Move the assignment for the data structure members "isoc_copy"
and "num_bufs" behind the source code for memory allocations
by this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/au0828/au0828-video.c | 5 ++---
1 file c