Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Hans Verkuil
On Thursday, October 06, 2011 02:32:33 Mauro Carvalho Chehab wrote: Em 05-10-2011 20:14, Sakari Ailus escreveu: Hi Mauro, On Wed, Oct 05, 2011 at 06:41:27PM -0300, Mauro Carvalho Chehab wrote: Em 05-10-2011 17:08, Laurent Pinchart escreveu: [clip] The pad-level API doesn't replace the

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Mauro Carvalho Chehab
Em 06-10-2011 04:23, Hans Verkuil escreveu: On Thursday, October 06, 2011 09:09:26 Hans Verkuil wrote: On Thursday, October 06, 2011 02:32:33 Mauro Carvalho Chehab wrote: Em 05-10-2011 20:14, Sakari Ailus escreveu: Hi Mauro, On Wed, Oct 05, 2011 at 06:41:27PM -0300, Mauro Carvalho Chehab

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Laurent Pinchart
Hi Mauro, On Thursday 06 October 2011 03:41:50 Mauro Carvalho Chehab wrote: Em 05-10-2011 20:41, Sakari Ailus escreveu: On Mon, Oct 03, 2011 at 04:36:44PM -0300, Mauro Carvalho Chehab wrote: Em 03-10-2011 16:01, Sakari Ailus escreveu: It's the same old issues again... let's discuss this

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Hans Verkuil
On Thursday 06 October 2011 13:51:15 Mauro Carvalho Chehab wrote: Em 06-10-2011 04:23, Hans Verkuil escreveu: On Thursday, October 06, 2011 09:09:26 Hans Verkuil wrote: On Thursday, October 06, 2011 02:32:33 Mauro Carvalho Chehab wrote: Also, I couldn't see a consense about input selection

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Mauro Carvalho Chehab
Em 06-10-2011 09:06, Hans Verkuil escreveu: On Thursday 06 October 2011 13:51:15 Mauro Carvalho Chehab wrote: Em 06-10-2011 04:23, Hans Verkuil escreveu: On Thursday, October 06, 2011 09:09:26 Hans Verkuil wrote: On Thursday, October 06, 2011 02:32:33 Mauro Carvalho Chehab wrote: Also, I

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-06 Thread Sylwester Nawrocki
On 10/06/2011 02:06 PM, Hans Verkuil wrote: On Thursday 06 October 2011 13:51:15 Mauro Carvalho Chehab wrote: Em 06-10-2011 04:23, Hans Verkuil escreveu: On Thursday, October 06, 2011 09:09:26 Hans Verkuil wrote: On Thursday, October 06, 2011 02:32:33 Mauro Carvalho Chehab wrote: Also, I

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Laurent Pinchart
Hi Mauro, On Monday 03 October 2011 23:56:06 Mauro Carvalho Chehab wrote: Em 03-10-2011 18:44, Laurent Pinchart escreveu: On Monday 03 October 2011 21:16:45 Mauro Carvalho Chehab wrote: Em 03-10-2011 08:53, Laurent Pinchart escreveu: On Monday 03 October 2011 11:53:44 Javier Martinez

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Laurent Pinchart
Hi Javier, On Tuesday 04 October 2011 00:37:27 Javier Martinez Canillas wrote: Hello, Reading the last emails I understand that still isn't a consensus on the way this has to be made. If it has to be implemented at the video device node level or at the sub-device level. And if it has to be

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Laurent Pinchart
Hi Hans, On Tuesday 04 October 2011 09:03:59 Hans Verkuil wrote: On Tuesday, October 04, 2011 07:31:27 Mauro Carvalho Chehab wrote: Em 03-10-2011 19:37, Javier Martinez Canillas escreveu: On Mon, Oct 3, 2011 at 11:56 PM, Mauro Carvalho Chehab wrote: Em 03-10-2011 18:44, Laurent Pinchart

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Mauro Carvalho Chehab
Em 05-10-2011 17:08, Laurent Pinchart escreveu: Hi Mauro, On Monday 03 October 2011 23:56:06 Mauro Carvalho Chehab wrote: Em 03-10-2011 18:44, Laurent Pinchart escreveu: On Monday 03 October 2011 21:16:45 Mauro Carvalho Chehab wrote: Em 03-10-2011 08:53, Laurent Pinchart escreveu: On Monday

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Mauro Carvalho Chehab
Em 05-10-2011 17:54, Laurent Pinchart escreveu: Hi Hans, On Tuesday 04 October 2011 09:03:59 Hans Verkuil wrote: On Tuesday, October 04, 2011 07:31:27 Mauro Carvalho Chehab wrote: Em 03-10-2011 19:37, Javier Martinez Canillas escreveu: On Mon, Oct 3, 2011 at 11:56 PM, Mauro Carvalho Chehab

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Javier Martinez Canillas
On Wed, Oct 5, 2011 at 11:48 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Em 05-10-2011 17:54, Laurent Pinchart escreveu: Hi Hans, On Tuesday 04 October 2011 09:03:59 Hans Verkuil wrote: On Tuesday, October 04, 2011 07:31:27 Mauro Carvalho Chehab wrote: Em 03-10-2011 19:37,

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Sakari Ailus
On Mon, Oct 03, 2011 at 11:39:31PM +0200, Laurent Pinchart wrote: Sorry ? We already have format setting at the pad level, and that's used by drivers and applications. It's one key feature of the V4L2/MC API. A tiny additional note: this feature is actuall necessary since e.g. OMAP 3 ISP CCDC

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Sakari Ailus
On Mon, Oct 03, 2011 at 04:36:44PM -0300, Mauro Carvalho Chehab wrote: Em 03-10-2011 16:01, Sakari Ailus escreveu: On Mon, Oct 03, 2011 at 03:53:54PM -0300, Mauro Carvalho Chehab wrote: Yes, you're right. I should not try to answer emails when I'm lazy enough to not look in to the code

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Mauro Carvalho Chehab
Em 05-10-2011 20:14, Sakari Ailus escreveu: Hi Mauro, On Wed, Oct 05, 2011 at 06:41:27PM -0300, Mauro Carvalho Chehab wrote: Em 05-10-2011 17:08, Laurent Pinchart escreveu: [clip] The pad-level API doesn't replace the V4L2 API, it complements it. I'm of course not advocating modifying any

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-05 Thread Mauro Carvalho Chehab
Em 05-10-2011 20:41, Sakari Ailus escreveu: On Mon, Oct 03, 2011 at 04:36:44PM -0300, Mauro Carvalho Chehab wrote: Em 03-10-2011 16:01, Sakari Ailus escreveu: On Mon, Oct 03, 2011 at 03:53:54PM -0300, Mauro Carvalho Chehab wrote: Yes, you're right. I should not try to answer emails when I'm

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-04 Thread Hans Verkuil
On Tuesday, October 04, 2011 07:31:27 Mauro Carvalho Chehab wrote: Em 03-10-2011 19:37, Javier Martinez Canillas escreveu: Hello, Reading the last emails I understand that still isn't a consensus on the way this has to be made. True. If it has to be implemented at the video

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-04 Thread Javier Martinez Canillas
On Tue, Oct 4, 2011 at 7:31 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: For now, I propose you to just add/improve the auto-detection on the existing callbacks. We need to reach a consensus before working at the pad level. Ok, I'll do that using saa7115 driver as a reference as

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-04 Thread Mauro Carvalho Chehab
Em 04-10-2011 04:03, Hans Verkuil escreveu: On Tuesday, October 04, 2011 07:31:27 Mauro Carvalho Chehab wrote: Em 03-10-2011 19:37, Javier Martinez Canillas escreveu: Hello, Reading the last emails I understand that still isn't a consensus on the way this has to be made. True. If it has

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Hans Verkuil
On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: On Sun, Oct 2, 2011 at 6:30 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Javier, Thanks for the patch! It's very interesting to see a driver for a video decoder

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Javier Martinez Canillas
On Mon, Oct 3, 2011 at 8:30 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: Yes, I'll change that.  static const struct v4l2_subdev_video_ops tvp5150_video_ops = {      

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Laurent Pinchart
Hi Hans, On Monday 03 October 2011 08:30:25 Hans Verkuil wrote: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: On Sun, Oct 2, 2011 at 6:30 PM, Sakari Ailus wrote: [snip] static const struct

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Javier Martinez Canillas
On Mon, Oct 3, 2011 at 10:39 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Hans, On Monday 03 October 2011 08:30:25 Hans Verkuil wrote: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: On Sun, Oct

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Sakari Ailus
On Sun, Oct 02, 2011 at 11:18:29PM +0200, Javier Martinez Canillas wrote: On Sun, Oct 2, 2011 at 6:30 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Javier, Thanks for the patch! It's very interesting to see a driver for a video decoder using the MC interface. Before this we've had just

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Laurent Pinchart
Hi Javier, On Monday 03 October 2011 11:53:44 Javier Martinez Canillas wrote: [snip] Laurent, I have a few questions about MCF and the OMAP3ISP driver if you are so kind to answer. 1- User-space programs that are not MCF aware negotiate the format with the V4L2 device (i.e: OMAP3 ISP CCDC

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2011 03:30, Hans Verkuil escreveu: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: On Sun, Oct 2, 2011 at 6:30 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Javier, Thanks for the patch! It's very interesting

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2011 04:11, Javier Martinez Canillas escreveu: On Mon, Oct 3, 2011 at 8:30 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: Yes, I'll change that. static const

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2011 06:53, Javier Martinez Canillas escreveu: On Mon, Oct 3, 2011 at 10:39 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Hans, On Monday 03 October 2011 08:30:25 Hans Verkuil wrote: On Monday, October 03, 2011 04:17:06 Mauro Carvalho Chehab wrote: Em 02-10-2011

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2011 18:44, Laurent Pinchart escreveu: Hi Mauro, On Monday 03 October 2011 21:16:45 Mauro Carvalho Chehab wrote: Em 03-10-2011 08:53, Laurent Pinchart escreveu: On Monday 03 October 2011 11:53:44 Javier Martinez Canillas wrote: [snip] Laurent, I have a few questions about MCF

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Javier Martinez Canillas
Hello, Reading the last emails I understand that still isn't a consensus on the way this has to be made. If it has to be implemented at the video device node level or at the sub-device level. And if it has to be made in kernel or user-space. On Mon, Oct 3, 2011 at 11:56 PM, Mauro Carvalho Chehab

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-03 Thread Mauro Carvalho Chehab
Em 03-10-2011 19:37, Javier Martinez Canillas escreveu: Hello, Reading the last emails I understand that still isn't a consensus on the way this has to be made. True. If it has to be implemented at the video device node level or at the sub-device level. And if it has to be made in kernel

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-02 Thread Sakari Ailus
Hi Javier, Thanks for the patch! It's very interesting to see a driver for a video decoder using the MC interface. Before this we've had just image sensors. Javier Martinez Canillas wrote: The tvp5150 video decoder is usually used on a video pipeline with several video processing integrated

Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-10-02 Thread Mauro Carvalho Chehab
Em 02-10-2011 18:18, Javier Martinez Canillas escreveu: On Sun, Oct 2, 2011 at 6:30 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Javier, Thanks for the patch! It's very interesting to see a driver for a video decoder using the MC interface. Before this we've had just image sensors.

[PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

2011-09-30 Thread Javier Martinez Canillas
The tvp5150 video decoder is usually used on a video pipeline with several video processing integrated circuits. So the driver has to be migrated to the new media device API to reflect this at the software level. Also the tvp5150 is able to detect what is the video standard at which the device is