Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-12-09 Thread Maxime Ripard
On Mon, Dec 08, 2014 at 09:19:02AM +0100, Hans de Goede wrote: Hi, On 07-12-14 19:08, Maxime Ripard wrote: On Wed, Dec 03, 2014 at 10:49:20AM +0100, Hans de Goede wrote: snip So it should not have a simple-bus compatible either, and as such we cannot simply change the mod0 driver from

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-12-08 Thread Hans de Goede
Hi, On 07-12-14 19:08, Maxime Ripard wrote: On Wed, Dec 03, 2014 at 10:49:20AM +0100, Hans de Goede wrote: snip So it should not have a simple-bus compatible either, and as such we cannot simply change the mod0 driver from of_clk_define to a platform driver because then we need to

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-12-07 Thread Maxime Ripard
On Wed, Dec 03, 2014 at 10:49:20AM +0100, Hans de Goede wrote: Hi, On 12/02/2014 04:45 PM, Maxime Ripard wrote: Ok, so thinking more about this, I'm still convinced that the MFD framework is only getting in the way here. You still haven't said of what exactly it's getting in the way

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-12-03 Thread Hans de Goede
Hi, On 12/02/2014 04:45 PM, Maxime Ripard wrote: Ok, so thinking more about this, I'm still convinced that the MFD framework is only getting in the way here. You still haven't said of what exactly it's getting in the way of. Of using of_clk_define to bind to the mod0 clk in the prcm,

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-12-02 Thread Maxime Ripard
Hi, On Fri, Nov 28, 2014 at 02:37:14PM +0100, Hans de Goede wrote: Hi, On 11/27/2014 08:05 PM, Maxime Ripard wrote: Hi, On Thu, Nov 27, 2014 at 11:10:51AM +0100, Hans de Goede wrote: Hi, On 11/27/2014 10:28 AM, Chen-Yu Tsai wrote: Hi, On Thu, Nov 27, 2014 at 4:41 PM, Hans de Goede

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-28 Thread Hans de Goede
Hi, On 11/27/2014 08:05 PM, Maxime Ripard wrote: Hi, On Thu, Nov 27, 2014 at 11:10:51AM +0100, Hans de Goede wrote: Hi, On 11/27/2014 10:28 AM, Chen-Yu Tsai wrote: Hi, On Thu, Nov 27, 2014 at 4:41 PM, Hans de Goede hdego...@redhat.com wrote: snip I notice that you've not responded to

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Hans de Goede
Hi, On 11/26/2014 10:13 PM, Maxime Ripard wrote: Hi, On Tue, Nov 25, 2014 at 09:29:21AM +0100, Hans de Goede wrote: Hi, On 11/24/2014 11:03 PM, Maxime Ripard wrote: On Fri, Nov 21, 2014 at 10:13:10AM +0100, Hans de Goede wrote: Hi, On 11/21/2014 09:49 AM, Maxime Ripard wrote: Hi, On

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Chen-Yu Tsai
Hi, On Thu, Nov 27, 2014 at 4:41 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 11/26/2014 10:13 PM, Maxime Ripard wrote: Hi, On Tue, Nov 25, 2014 at 09:29:21AM +0100, Hans de Goede wrote: Hi, On 11/24/2014 11:03 PM, Maxime Ripard wrote: On Fri, Nov 21, 2014 at 10:13:10AM

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Hans de Goede
Hi, On 11/27/2014 10:28 AM, Chen-Yu Tsai wrote: Hi, On Thu, Nov 27, 2014 at 4:41 PM, Hans de Goede hdego...@redhat.com wrote: snip I notice that you've not responded to my proposal to simple make the clock node a child node of the clocks node in the dt, that should work nicely, and avoid

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Boris Brezillon
Hi, On Wed, 26 Nov 2014 22:13:18 +0100 Maxime Ripard maxime.rip...@free-electrons.com wrote: [...] I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was not really a mod0 clk. From what I could gather from the source code, it seems to have a wider m divider, so we could

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Maxime Ripard
On Thu, Nov 27, 2014 at 09:41:09AM +0100, Hans de Goede wrote: Hi, On 11/26/2014 10:13 PM, Maxime Ripard wrote: Hi, On Tue, Nov 25, 2014 at 09:29:21AM +0100, Hans de Goede wrote: Hi, On 11/24/2014 11:03 PM, Maxime Ripard wrote: On Fri, Nov 21, 2014 at 10:13:10AM +0100, Hans de Goede

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Maxime Ripard
Hi, On Thu, Nov 27, 2014 at 11:10:51AM +0100, Hans de Goede wrote: Hi, On 11/27/2014 10:28 AM, Chen-Yu Tsai wrote: Hi, On Thu, Nov 27, 2014 at 4:41 PM, Hans de Goede hdego...@redhat.com wrote: snip I notice that you've not responded to my proposal to simple make the clock node a

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-27 Thread Maxime Ripard
On Thu, Nov 27, 2014 at 05:40:56PM +0100, Boris Brezillon wrote: Hi, On Wed, 26 Nov 2014 22:13:18 +0100 Maxime Ripard maxime.rip...@free-electrons.com wrote: [...] I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was not really a mod0 clk. From what I could gather

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-26 Thread Maxime Ripard
Hi, On Tue, Nov 25, 2014 at 09:29:21AM +0100, Hans de Goede wrote: Hi, On 11/24/2014 11:03 PM, Maxime Ripard wrote: On Fri, Nov 21, 2014 at 10:13:10AM +0100, Hans de Goede wrote: Hi, On 11/21/2014 09:49 AM, Maxime Ripard wrote: Hi, On Thu, Nov 20, 2014 at 04:55:22PM +0100, Hans de

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-25 Thread Hans de Goede
Hi, On 11/24/2014 11:03 PM, Maxime Ripard wrote: On Fri, Nov 21, 2014 at 10:13:10AM +0100, Hans de Goede wrote: Hi, On 11/21/2014 09:49 AM, Maxime Ripard wrote: Hi, On Thu, Nov 20, 2014 at 04:55:22PM +0100, Hans de Goede wrote: Add a driver for mod0 clocks found in the prcm. Currently

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-25 Thread Hans de Goede
Hi, On 11/25/2014 09:29 AM, Hans de Goede wrote: snip Well one reasons why clocks are instantiated the way they are is to have them available as early as possible, which is really convenient and works really well. You are asking for a whole lot of stuff to be changed, arguably in a way which

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-24 Thread Maxime Ripard
On Fri, Nov 21, 2014 at 10:13:10AM +0100, Hans de Goede wrote: Hi, On 11/21/2014 09:49 AM, Maxime Ripard wrote: Hi, On Thu, Nov 20, 2014 at 04:55:22PM +0100, Hans de Goede wrote: Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-21 Thread Maxime Ripard
Hi, On Thu, Nov 20, 2014 at 04:55:22PM +0100, Hans de Goede wrote: Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the ir clock. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/clock/sunxi.txt | 1

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-21 Thread Hans de Goede
Hi, On 11/21/2014 09:49 AM, Maxime Ripard wrote: Hi, On Thu, Nov 20, 2014 at 04:55:22PM +0100, Hans de Goede wrote: Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the ir clock. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-20 Thread Hans de Goede
Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the ir clock. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/clock/sunxi.txt | 1 + drivers/clk/sunxi/Makefile| 2 +-

Re: [linux-sunxi] [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-20 Thread Chen-Yu Tsai
Hi, On Thu, Nov 20, 2014 at 7:55 AM, Hans de Goede hdego...@redhat.com wrote: Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the ir clock. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [linux-sunxi] [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

2014-11-20 Thread Hans de Goede
Hi, On 11/20/2014 07:24 PM, Chen-Yu Tsai wrote: Hi, On Thu, Nov 20, 2014 at 7:55 AM, Hans de Goede hdego...@redhat.com wrote: Add a driver for mod0 clocks found in the prcm. Currently there is only one mod0 clocks in the prcm, the ir clock. Signed-off-by: Hans de Goede hdego...@redhat.com