Re: [PATCH 4/5] add V4L2 control functions

2018-02-05 Thread Hans Verkuil
On 02/05/2018 10:36 PM, Florian Echtler wrote: > Hello Hans, > > On Mon, 5 Feb 2018, Hans Verkuil wrote: >> On 02/05/2018 03:29 PM, Florian Echtler wrote: >>> + >>> +static int sur40_vidioc_queryctrl(struct file *file, void *fh, >>> + struct v4l2_queryctrl *qc) >> >>

Re: [PATCH 4/5] add V4L2 control functions

2018-02-05 Thread Florian Echtler
Hello Hans, On Mon, 5 Feb 2018, Hans Verkuil wrote: On 02/05/2018 03:29 PM, Florian Echtler wrote: + +static int sur40_vidioc_queryctrl(struct file *file, void *fh, + struct v4l2_queryctrl *qc) Sorry, but this is very wrong. Use the control framework instead. See

Re: [PATCH 4/5] add V4L2 control functions

2018-02-05 Thread Hans Verkuil
On 02/05/2018 03:29 PM, Florian Echtler wrote: > Signed-off-by: Florian Echtler > --- > drivers/input/touchscreen/sur40.c | 114 > ++ > 1 file changed, 114 insertions(+) > > diff --git a/drivers/input/touchscreen/sur40.c >

[PATCH 4/5] add V4L2 control functions

2018-02-05 Thread Florian Echtler
Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 114 ++ 1 file changed, 114 insertions(+) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 63c7264b..c4b7cf1 100644 ---