Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi again, On 2018-05-11 13:10:37 +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > > The crop_scale routine uses the crop rectangle memebers to configure the > > VIN clipping rectangle. When crop is not configured all

Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > The crop_scale routine uses the crop rectangle memebers to configure the > VIN clipping rectangle. When crop is not configured all its fields are > 0s, and setting the clipping rectangle vertical and horizontal

[PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Jacopo Mondi
The crop_scale routine uses the crop rectangle memebers to configure the VIN clipping rectangle. When crop is not configured all its fields are 0s, and setting the clipping rectangle vertical and horizontal extensions to (0 - 1) causes the registers to be written with an incorrect 0x