[PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the local reference in the v4l2_event_unsubscribe function. 2: Setting sev-fh to NULL causes problems for the del op added in the next patch of this

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

On Thursday, October 27, 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the local reference in the v4l2_event_unsubscribe function. Not true. v4l2-ctrls.c may

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

Hi, Thanks for the reviews! On 10/27/2011 02:20 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

Hi Hans, On Friday 28 October 2011 10:35:54 Hans de Goede wrote: On 10/27/2011 02:20 PM, Laurent Pinchart wrote: On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

Hi Hans, On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the local reference in the v4l2_event_unsubscribe function. 2: Setting sev-fh to