Re: [PATCH 4/9] [media] pci: mantis: Remove redundant pci_set_drvdata

2013-09-30 Thread Manu Abraham
On Fri, Sep 20, 2013 at 2:06 PM, Sachin Kamat  wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat 
> Cc: Manu Abraham 
Acked-by: Manu Abraham 
> ---
>  drivers/media/pci/mantis/mantis_pci.c |2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/pci/mantis/mantis_pci.c 
> b/drivers/media/pci/mantis/mantis_pci.c
> index a846036..9e89e04 100644
> --- a/drivers/media/pci/mantis/mantis_pci.c
> +++ b/drivers/media/pci/mantis/mantis_pci.c
> @@ -143,7 +143,6 @@ fail1:
>
>  fail0:
> dprintk(MANTIS_ERROR, 1, "ERROR: <%d> exiting", ret);
> -   pci_set_drvdata(pdev, NULL);
> return ret;
>  }
>  EXPORT_SYMBOL_GPL(mantis_pci_init);
> @@ -161,7 +160,6 @@ void mantis_pci_exit(struct mantis_pci *mantis)
> }
>
> pci_disable_device(pdev);
> -   pci_set_drvdata(pdev, NULL);
>  }
>  EXPORT_SYMBOL_GPL(mantis_pci_exit);
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 4/9] [media] pci: mantis: Remove redundant pci_set_drvdata

2013-09-20 Thread Sachin Kamat
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat 
Cc: Manu Abraham 
---
 drivers/media/pci/mantis/mantis_pci.c |2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/pci/mantis/mantis_pci.c 
b/drivers/media/pci/mantis/mantis_pci.c
index a846036..9e89e04 100644
--- a/drivers/media/pci/mantis/mantis_pci.c
+++ b/drivers/media/pci/mantis/mantis_pci.c
@@ -143,7 +143,6 @@ fail1:
 
 fail0:
dprintk(MANTIS_ERROR, 1, "ERROR: <%d> exiting", ret);
-   pci_set_drvdata(pdev, NULL);
return ret;
 }
 EXPORT_SYMBOL_GPL(mantis_pci_init);
@@ -161,7 +160,6 @@ void mantis_pci_exit(struct mantis_pci *mantis)
}
 
pci_disable_device(pdev);
-   pci_set_drvdata(pdev, NULL);
 }
 EXPORT_SYMBOL_GPL(mantis_pci_exit);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html