[PATCH 5/12] drivers/media/video/uvc: Correct size given to memset

[Julia Lawall]

From: Julia Lawall ju...@diku.dk

Memset should be given the size of the structure, not the size of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// smpl
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// /smpl

Signed-off-by: Julia Lawall ju...@diku.dk

---
 drivers/media/video/uvc/uvc_video.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/media/video/uvc/uvc_video.c 
b/drivers/media/video/uvc/uvc_video.c
--- a/drivers/media/video/uvc/uvc_video.c
+++ b/drivers/media/video/uvc/uvc_video.c
@@ -145,7 +145,7 @@ static int uvc_get_video_ctrl(struct uvc
uvc_warn_once(stream-dev, UVC_WARN_MINMAX, UVC non 
compliance - GET_MIN/MAX(PROBE) incorrectly 
supported. Enabling workaround.\n);
-   memset(ctrl, 0, sizeof ctrl);
+   memset(ctrl, 0, sizeof *ctrl);
ctrl-wCompQuality = le16_to_cpup((__le16 *)data);
ret = 0;
goto out;
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset

[Laurent Pinchart]

Hi Julia,

thanks for the patch.

On Wednesday 09 December 2009 20:23:49 Julia Lawall wrote:
 From: Julia Lawall ju...@diku.dk
 
 Memset should be given the size of the structure, not the size of the
  pointer.
 
 The semantic patch that makes this change is as follows:
 (http://coccinelle.lip6.fr/)
 
 // smpl
 @@
 type T;
 T *x;
 expression E;
 @@
 
 memset(x, E, sizeof(
 + *
  x))
 // /smpl
 
 Signed-off-by: Julia Lawall ju...@diku.dk

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html