Re: [PATCH 5/5] drm: panel: simple-panel: add bus format information for foxlink panel

2014-09-23 Thread Thierry Reding 
On Tue, Jul 22, 2014 at 02:23:47PM +0200, Boris BREZILLON wrote:
 Foxlink's fl500wvr00-a0t supports RGB888 format.
 
 Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com
 ---
  drivers/gpu/drm/panel/panel-simple.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/gpu/drm/panel/panel-simple.c 
 b/drivers/gpu/drm/panel/panel-simple.c
 index 42fd6d1..f1e49fd 100644
 --- a/drivers/gpu/drm/panel/panel-simple.c
 +++ b/drivers/gpu/drm/panel/panel-simple.c
 @@ -428,6 +428,7 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
   .width = 108,
   .height = 65,
   },
 + .bus_format = VIDEO_BUS_FMT_RGB888_1X24,

This is really equivalent to .bpc = 8. Didn't you say you had other
use-cases where .bpc wasn't sufficient?

Thierry


pgpACzaTCYnMu.pgp
Description: PGP signature

Re: [PATCH 5/5] drm: panel: simple-panel: add bus format information for foxlink panel

2014-09-23 Thread Boris BREZILLON 
Hi Thierry,

On Tue, 23 Sep 2014 16:06:13 +0200
Thierry Reding thierry.red...@gmail.com wrote:

 On Tue, Jul 22, 2014 at 02:23:47PM +0200, Boris BREZILLON wrote:
  Foxlink's fl500wvr00-a0t supports RGB888 format.
  
  Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com
  ---
   drivers/gpu/drm/panel/panel-simple.c | 1 +
   1 file changed, 1 insertion(+)
  
  diff --git a/drivers/gpu/drm/panel/panel-simple.c 
  b/drivers/gpu/drm/panel/panel-simple.c
  index 42fd6d1..f1e49fd 100644
  --- a/drivers/gpu/drm/panel/panel-simple.c
  +++ b/drivers/gpu/drm/panel/panel-simple.c
  @@ -428,6 +428,7 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = 
  {
  .width = 108,
  .height = 65,
  },
  +   .bus_format = VIDEO_BUS_FMT_RGB888_1X24,
 
 This is really equivalent to .bpc = 8. Didn't you say you had other
 use-cases where .bpc wasn't sufficient?

Yes, the HLCDC support RGB565 where you don't have the same number of
bits for each color (Red and Blue = 5 bits, Green = 6 bits), and thus
can't be encoded in the bpc field.

 
 Thierry



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] drm: panel: simple-panel: add bus format information for foxlink panel

2014-07-22 Thread Boris BREZILLON 
Foxlink's fl500wvr00-a0t supports RGB888 format.

Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com
---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 42fd6d1..f1e49fd 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -428,6 +428,7 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
.width = 108,
.height = 65,
},
+   .bus_format = VIDEO_BUS_FMT_RGB888_1X24,
 };
 
 static const struct drm_display_mode lg_lp129qe_mode = {
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html