Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-20 Thread Laurent Pinchart
Hi Mauro, On Thursday, 20 September 2018 17:44:53 EEST Mauro Carvalho Chehab wrote: > Em Fri, 07 Sep 2018 14:46:34 +0300 Laurent Pinchart escreveu: > > Hi Mauro, > > > > As maintainers should be held to the same level of obligations as > > developers, and to avoid demotivating reviewers, could

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-20 Thread Mauro Carvalho Chehab
Em Fri, 07 Sep 2018 14:46:34 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > As maintainers should be held to the same level of obligations as developers, > and to avoid demotivating reviewers, could you handle comments you receive > before pushing your own patches to your tree ? There

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-11 Thread Laurent Pinchart
Hi Mauro, On Friday, 7 September 2018 14:46:34 EEST Laurent Pinchart wrote: > Hi Mauro, > > As maintainers should be held to the same level of obligations as > developers, and to avoid demotivating reviewers, could you handle comments > you receive before pushing your own patches to your tree ?

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-07 Thread Laurent Pinchart
Hi Mauro, As maintainers should be held to the same level of obligations as developers, and to avoid demotivating reviewers, could you handle comments you receive before pushing your own patches to your tree ? There should be no maintainer privilege here. On Wednesday, 8 August 2018 18:45:49

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-08-08 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. The subject line should be "media: omap3isp: ...". On Wednesday, 8 August 2018 17:52:55 EEST Mauro Carvalho Chehab wrote: > As sparse complains: > drivers/media/platform/omap3isp/isp.c:303:39: warning: Using plain > integer > as NULL pointer > > when a

[PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-08-08 Thread Mauro Carvalho Chehab
As sparse complains: drivers/media/platform/omap3isp/isp.c:303:39: warning: Using plain integer as NULL pointer when a struct is initialized with { 0 }, actually the first element of the struct is initialized with zeros, initializing the other elements recursively. That can even generate