Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Hi, hverkuil wrote: + if (sev-ops sev-ops-add) { + int ret = sev-ops-add(sev); + if (ret) { + sev-ops = NULL; + v4l2_event_unsubscribe(fh, sub); + return ret; + } The problem here

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-30 Thread Hans Verkuil
On Thursday, October 27, 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this.

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-30 Thread Hans Verkuil
On Sunday, October 30, 2011 12:17:28 Hans Verkuil wrote: On Thursday, October 27, 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe /

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-28 Thread Hans de Goede
Hi, On 10/27/2011 02:30 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe /

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com ---